Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stopgap solution for charge limitations until kernel patches allow us to set charge limits. Currently it uses the lowest possible limit I've found for charging when above the charge threshhold set in the config file. This was tested on the AYN Thor.
This is just the backend daemon and I have not included implementation into armada-control for this feature. I have it enabled automatically, and error handling is done in script, with the daemon not restarting if it doesn't know how to set the limits.
This will both need a UI component and device testing before it should be upstreamed, but the backend here would be fine to put in for users who don't mind changing a config file.