Repository navigation
fix(kernel): stop the idle SD controller interrupting CPU0 on SM8550 and SM8750 - #653
Open
ouroboros420 wants to merge 1 commit into
Open
ouroboros420 wants to merge 1 commit into
ouroboros420 wants to merge 1 commit into
Conversation
…and SM8750 sdhci-msm's runtime suspend gates the clocks but leaves the controller interrupts enabled, and sdhci_irq() returns IRQ_NONE while the host is runtime suspended, so nothing acknowledges them. With the rootfs on microSD that is 15-50 unhandled interrupts a second on CPU0 whenever the card is idle, and it keeps RPMh out of AOSD/CXSD in s2idle (armada-os#274). 0537 masks them while the host is runtime suspended. Every SM8550 and SM8750 board here detects the card through a cd-gpio, so hotplug is unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdhci-msm leaves the controller interrupts enabled across runtime suspend, but sdhci_irq() returns IRQ_NONE while the host is runtime suspended. With the rootfs on microSD that's 15-50 unhandled interrupts a second on CPU0 whenever the card is idle, and it keeps RPMh out of AOSD/CXSD in s2idle (#274). 0537, from drewano's SM8550 sleep stack, masks them while the host is runtime suspended. Every SM8550/SM8750 board uses a cd-gpio, so hotplug is unaffected.
Needs testing at idle,
grep mmc0 /proc/interrupts10 s apart should barely move.