Add logic to multilib.yaml to handle cases of armebv7a_soft_nofp and armebv7a_hard_vfpv3_d16 variants #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…armebv7a_hard_vfpv3_d16 variants These variants were missing some logic in multilib.yaml: some of the flag matching rules existed only for little endian. Thus they had to be copied for big endian as well. Besides the changes to multilib.yaml, tests have been added to properly test the library selection of the variants.
pratlucas
approved these changes
Feb 17, 2025
simpal01
pushed a commit
to simpal01/arm-toolchain
that referenced
this pull request
Feb 28, 2025
…armebv7a_hard_vfpv3_d16 variants. These variants were missing some logic in multilib.yaml: some of the flag matching rules existed only for little endian. Thus they had to be copied for big endian as well. Besides the changes to multilib.yaml, tests have been added to properly test the library selection of the variants. (cherry picked from arm#99) Add AArch64 R-profile soft nofp variants (LE and BE). (cherry picked from arm#102) Remove -mno-unaligned-access flag from AArch32 big endian variants. The big endian library can be selected with or without the -mno-unaligned-access flag. Currently, selecting the variants below requires explicitly passing -mno-unaligned-access. This change removes the flag from the selection criteria, ensuring that below variants can be selected regardless of whether -mno-unaligned-access is used. - armebv7a_soft_nofp - armebv7a_soft_nofp_exn_rtti - armebv7a_hard_vfpv3_d16 - armebv7a_hard_vfpv3_d16_exn_rtti - armebv7a_soft_vfpv3_d16_exn_rtti - armebv7a_soft_vfpv3_d16 (cherry picked from arm#115)
simpal01
pushed a commit
to simpal01/arm-toolchain
that referenced
this pull request
Feb 28, 2025
…armebv7a_hard_vfpv3_d16 variants (arm#99) These variants were missing some logic in multilib.yaml: some of the flag matching rules existed only for little endian. Thus they had to be copied for big endian as well. Besides the changes to multilib.yaml, tests have been added to properly test the library selection of the variants. (cherry picked from commit 128f026)
simpal01
pushed a commit
that referenced
this pull request
Feb 28, 2025
…armebv7a_hard_vfpv3_d16 variants (#99) These variants were missing some logic in multilib.yaml: some of the flag matching rules existed only for little endian. Thus they had to be copied for big endian as well. Besides the changes to multilib.yaml, tests have been added to properly test the library selection of the variants. (cherry picked from commit 128f026)
This was referenced Feb 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These variants were missing some logic in multilib.yaml: some of the flag matching rules existed only for little endian. Thus they had to be copied for big endian as well.
Besides the changes to multilib.yaml, tests have been added to properly test the library selection of the variants.