[ATfE] Use python executable path for picolibc tests #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the wrapper command for running picolibc tests in ATfE includes a direct call to the `picolibc-test-wrapper.py` script, relying on the script's shebang line to invoke the python interpreter. This is a problem for invoking tests on Windows platofrms, as the naming of the Python 3 executable is not consistent with the one used on Unix - i.e. python vs python3. To fix this problem, this change adds the path for the python executable to that call. The path used is the one discovered by CMake as part of the `find_package(Python3 ...)` command.
statham-arm
approved these changes
Feb 5, 2025
pratlucas
added a commit
to pratlucas/arm-toolchain
that referenced
this pull request
Feb 10, 2025
Currently, the wrapper command for running picolibc tests in ATfE includes a direct call to the `picolibc-test-wrapper.py` script, relying on the script's shebang line to invoke the python interpreter. This is a problem for invoking tests on Windows platofrms, as the naming of the Python 3 executable is not consistent with the one used on Unix - i.e. python vs python3. To fix this problem, this change adds the path for the python executable to that call. The path used is the one discovered by CMake as part of the `find_package(Python3 ...)` command. Cherry-picked from commit 9b283bc (arm#70)
pratlucas
added a commit
that referenced
this pull request
Feb 10, 2025
Currently, the wrapper command for running picolibc tests in ATfE includes a direct call to the `picolibc-test-wrapper.py` script, relying on the script's shebang line to invoke the python interpreter. This is a problem for invoking tests on Windows platofrms, as the naming of the Python 3 executable is not consistent with the one used on Unix - i.e. python vs python3. To fix this problem, this change adds the path for the python executable to that call. The path used is the one discovered by CMake as part of the `find_package(Python3 ...)` command. Cherry-picked from commit 9b283bc (#70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the wrapper command for running picolibc tests in ATfE
includes a direct call to the
picolibc-test-wrapper.pyscript, relyingon the script's shebang line to invoke the python interpreter. This is a
problem for invoking tests on Windows platofrms, as the naming of the
Python 3 executable is not consistent with the one used on Unix - i.e.
python vs python3.
To fix this problem, this change adds the path for the python executable
to that call. The path used is the one discovered by CMake as part of
the
find_package(Python3 ...)command.