[ATfE] Remove downstream patch that defined _LIBCPP_HAS_C8RTOMB_MBRTOC8 #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r32_t picolibc recently ([link](picolibc/picolibc@f6f6875)) added support for char16_t and char32_t. These xfails aren't needed anymore.
PR llvm/llvm-project#152724 adds logic to define the `_LIBCPP_HAS_C8RTOMB_MBRTOC8` macro depending on the picolibc support for `char8_t` functions. With this change we don't need a downstream patch anymore.
vhscampos
deleted the
remove-downstream-patch-_LIBCPP_HAS_C8RTOMB_MBRTOC8
branch
|
This pull review modifies files outside of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR llvm/llvm-project#152724 adds logic to define
the
_LIBCPP_HAS_C8RTOMB_MBRTOC8macro depending on the picolibcsupport for
char8_tfunctions.With this change we don't need a downstream patch anymore.