[ATfL] build.sh modifications to accommodate the upstream changes #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the upstream commit [1] we could not build the product anymore. Several things had to change: - path to libc++ includes must be forcibly provided to the runtimes - flang-rt must be explicitly listed for building - we must explicitly ensure both static and shared build of flang-rt - the `-DLLVM_ENABLE_LIBCXX=ON` flag has been removed to silence the compiler warnings [1] llvm/llvm-project@77581e2
pawosm-arm
force-pushed
the
users/pawosm-arm/atfl-build-script-recent-changes
branch
from
6bba4ce to
a9c1bfc
Compare
pawosm-arm
requested review from
DavidTruby,
pratlucas,
DaftanoPro,
dcandler,
garyjcarroll and
schander-arm
garyjcarroll
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upstream commit [1] we could not build the product anymore.
Several things had to change:
path to libc++ includes must be forcibly provided to the runtimes
flang-rt must be explicitly listed for building
we must explicitly ensure both static and shared build of flang-rt
the
-DLLVM_ENABLE_LIBCXX=ONflag has been removed to silence the compiler warnings[1] llvm/llvm-project@77581e2