Skip to content

chore(bench): remove unused lcs vector from benchmarks #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(bench): remove unused lcs vector from benchmarks #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
473cec5
chore(bench): remove unused lcs vector from benchmarks
MozirDmitriy Jul 19, 2025
08361ae
chore(bench): remove unused lcs vector from benchmarks
MozirDmitriy Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions relations/examples/bench-no-finalize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ impl ConstraintSynthesizer<Fr> for BenchCircuit {
let c = cs.new_witness_variable(|| Ok(self.c)).unwrap();
let mut variables = vec![a, b, c];
variables.reserve(3 * self.num_constraints);
let mut lcs = Vec::with_capacity(self.num_constraints);
// let mut lcs = Vec::with_capacity(self.num_constraints);

let mut rng_a = ark_std::rand::rngs::StdRng::seed_from_u64(0_u64);
let mut rng_b = ark_std::rand::rngs::StdRng::seed_from_u64(rng_a.gen::<u64>());
Expand Down Expand Up @@ -67,7 +67,7 @@ impl ConstraintSynthesizer<Fr> for BenchCircuit {
)
};
let extra_lc = cs.new_lc(extra_lc)?;
lcs.push(extra_lc);
// lcs.push(extra_lc);
cs.enforce_r1cs_constraint(|| a_i() + extra_lc, b_i, || c_i.into())?;
} else {
cs.enforce_r1cs_constraint(a_i, b_i, || c_i.into())?;
Expand Down
4 changes: 2 additions & 2 deletions relations/examples/bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ impl ConstraintSynthesizer<Fr> for BenchCircuit {
let c = cs.new_witness_variable(|| Ok(self.c)).unwrap();
let mut variables = vec![a, b, c];
variables.reserve(3 * self.num_constraints);
let mut lcs = Vec::with_capacity(self.num_constraints);
// let mut lcs = Vec::with_capacity(self.num_constraints);

let mut rng_a = ark_std::rand::rngs::StdRng::seed_from_u64(0u64);
let mut rng_b = ark_std::rand::rngs::StdRng::seed_from_u64(rng_a.gen::<u64>());
Expand Down Expand Up @@ -66,7 +66,7 @@ impl ConstraintSynthesizer<Fr> for BenchCircuit {
)
};
let extra_lc = cs.new_lc(extra_lc)?;
lcs.push(extra_lc);
// lcs.push(extra_lc);
cs.enforce_r1cs_constraint(|| a_i() + extra_lc, b_i, || c_i.into())?;
} else {
cs.enforce_r1cs_constraint(a_i, b_i, || c_i.into())?;
Expand Down