Remove circuit C and some lifetime specifiers from the type
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanleh
reviewed
Dec 15, 2020
|
LGTM mod the one comment! The merge for me should be fairly painless :) |
ryanleh
approved these changes
Dec 15, 2020
weikengchen
added a commit
that referenced
this pull request
Dec 17, 2020
…master` (#52) * Update for arkworks-rs/algebra#53 * Automatically pad the formatted input size to 2^k (#47) * support public input that is not 2^k * Update src/lib.rs Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu> * fmt Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu> * Add the benchmark (#48) * add bench * fix * fmt * multithread * update the remark * Remove circuit `C` and some lifetime specifiers from the type (#50) * remove c in type * fix * remove an unnecessary clone * Add serialization for Proof (#51) * add serialization for Proof * add unchecked serialization * fix bench and add uncompressed serialization * fix bench Co-authored-by: Ryan Lehmkuhl <ryanleh.ob@gmail.com> Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
This was referenced Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extracted part of the
constraintsPR.This part does two things:
C: CosntraintSynthesizerfrom many of the data structures' type parameters, since it is somehow unnecessary.This change might be breaking that may affect Ryan's project.
So, I hereby request Ryan (@ryanleh) for a review.