Skip to content

Conversation

Pratyush
Copy link
Member

Description


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Pratyush Pratyush requested review from a team as code owners January 12, 2024 22:07
@Pratyush Pratyush requested review from z-tech, mmagician and weikengchen and removed request for a team January 12, 2024 22:07
@mmagician
Copy link
Member

We're still at minimum supported rust-version = "1.70", so we'd need to bump to 1.75 first, which would be pretty limiting to some projects.

@Pratyush
Copy link
Member Author

We can hold off on this for a couple of release, just wanted to get this on the radar.

@mmagician mmagician added the do-not-merge-now Do not merge due to conflicts with more important PRs label Jan 14, 2024
@Pratyush
Copy link
Member Author

It's been a few releases, so maybe we can merge this now?

@mmagician
Copy link
Member

@Pratyush sounds good, could you also bump the minimum rust-version together with this PR?

@Pratyush Pratyush removed the do-not-merge-now Do not merge due to conflicts with more important PRs label Jun 19, 2024
@Pratyush
Copy link
Member Author

Done!

@Pratyush Pratyush enabled auto-merge June 19, 2024 13:24
@Pratyush Pratyush added this pull request to the merge queue Jun 19, 2024
Merged via the queue into master with commit 9ce37d5 Jun 19, 2024
@Pratyush Pratyush deleted the replace-base-field-iter branch June 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants