Implement wNAF-based MSM derived from Gemini #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michele Orrù <michele.orru@berkeley.edu> Co-authored-by: Horace Pan <horacepan@gmail.com>
Pratyush
requested review from
mmagician and
weikengchen
and removed request for
a team
Pratyush
changed the title
weikengchen
approved these changes
Dec 10, 2022
|
Hm this is giving an incorrect result. Any ideas @mmaker? EDIT: nvm I believe it's fixed now. |
|
Hey! Thank you so much for bringing this into algebra. I'm unlikely to help review and fix this properly before the 20th December. Skimming though it, I didn't find any blatant error -- In Gemini this was still giving the same result last time I tried? |
|
No worries! I think I've fixed the bug; I had updated how buckets are accessed when the digit was negative, and had done so incorrectly. It's fixed now, I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #450
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer