Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common fields into ModelParameters #365

Merged
merged 16 commits into from
Dec 22, 2021
Merged

Move common fields into ModelParameters #365

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1874af7
Move COFACTOR and COFACTOR_INV to the parent trait ModelParameters
alexander-zw Dec 11, 2021
5c26135
Move is_in_correct_subgroup_assuming_on_curve() into the parent trait…
alexander-zw Dec 11, 2021
7270544
Update changelog
alexander-zw Dec 11, 2021
1020349
Add more documentation
alexander-zw Dec 11, 2021
b090f46
[BROKEN] Move mul_bits into AffineCurve and replace MultipliablePoint…
alexander-zw Dec 12, 2021
6cc4a8f
Add associated type bounds and other PR suggestions
alexander-zw Dec 12, 2021
6a91830
Reword changelog entry
alexander-zw Dec 13, 2021
2bf97cb
Move mul_bits() implementation into AffineCurve
alexander-zw Dec 13, 2021
c0f801e
Remove duplicate function scale_by_cofactor()
alexander-zw Dec 15, 2021
42bcb54
Fix markdown lint issue
alexander-zw Dec 15, 2021
6b4876e
Merge branch 'master' into model-params
Pratyush Dec 22, 2021
7ab2461
Move more stuff to generic implementation
Pratyush Dec 22, 2021
0fb1e3d
Qualify `group` import
Pratyush Dec 22, 2021
5e7307e
Merge branch 'master' into model-params
Pratyush Dec 22, 2021
9b3b366
fmt
Pratyush Dec 22, 2021
bab4907
Merge branch 'model-params' of github.com:alexander-zw/algebra into p…
Pratyush Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix markdown lint issue
  • Loading branch information
@alexander-zw
alexander-zw committed Dec 15, 2021
commit 42bcb54d1f8cb3fb616132027229e02c90eb6f76
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
- [\#348](https://github.com/arkworks-rs/algebra/pull/348) (arc-ec) Rename `msm:{Fixed,Variable}BaseMSM:multi_scalar_mul` to `msm:{Fixed,Variable}:msm` to avoid redundancy.
- [\#359](https://github.com/arkworks-rs/algebra/pull/359) (ark-test-templates) Simplify the field and curve test macros.
- [\#365](https://github.com/arkworks-rs/algebra/pull/365) (arc-ec)
- Move `COFACTOR`, `COFACTOR_INV`, and `is_in_correct_subgroup_assuming_on_curve()` from `{SW,TE}ModelParameters` to `ModelParameters`.
- Add `mul_bits()` to `AffineCurve` and provide a default implementation of `mul()` using this.
- Move `COFACTOR`, `COFACTOR_INV`, and `is_in_correct_subgroup_assuming_on_curve()` from `{SW,TE}ModelParameters` to `ModelParameters`.
- Add `mul_bits()` to `AffineCurve` and provide a default implementation of `mul()` using this.
- Remove duplicate function `scale_by_cofactor()` from `short_weierstrass_jacobian::GroupAffine` and `twisted_edwards_extended::GroupAffine`

### Features
Expand Down