Improve ALSA PCM plugin compatibility on a2dp-sink, hfp-hf and hsp-hs #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For capture PCMs, Bluetooth does not report its delay, so the value given by the D-Bus interface is not useful to an ALSA PCM. Therefore report only the delay represented by the samples in the ring buffer; this is the minimum required to comply with the ALSA specification and is sufficient to support applications such as `alsaloop` which require a meaningful delay value to function correctly. Also discard any stale samples in the FIFO when preparing a capture PCM to to ensure a fresh start, especially after overrun.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| max_capacity = 1048576; /* Linux default max pipe size */ | ||
| } | ||
| fclose(proc_file); | ||
| if (target_capacity > max_capacity) |
Check failure
Code scanning / CodeQL
Missing return-value check for a 'scanf'-like function High
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 70.43% 69.92% -0.52%
==========================================
Files 96 96
Lines 16025 16178 +153
Branches 2515 2553 +38
==========================================
+ Hits 11288 11312 +24
- Misses 4618 4747 +129
Partials 119 119 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permit a BlueALSA PCM to be used more like a
hwPCM on a2dp-sink, hfp-hf and hsp-hs nodes by making the PCM capture delay value more useful, and by offering a choice of operating modes to suit different application requirements when a PCM exists but the stream does not offer any samples.Closes #743