-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godot 4.0 support #15
Conversation
# Global changes - removed type annotations in scripts - changed `VisualShaderNode.PORT_TYPE_VECTOR` references to `VisualShaderNode.PORT_TYPE_VECTOR_3D` # Specific changes `addons/shaderV/tools/random/randomGoldNoiseFloat.gdshader` - removed PI definition as it is now built-in `addons/shaderV/rgba/bloom.gd` `addons/shaderV/tools/random/randomGoldNoiseFloat.gd` - added a semicolon in the generated code `addons/shaderV/rgba/generate_shapes/scanLinesSharp.gd` `addons/shaderV/rgba/generate_shapes/stripesRandom.gd` - added cast to float in generated code `addons/shaderV/uv/animated/tilingNoffsetAnimated.gd` - changed `+=` to `=` in generated code # Visual shaders ## Sobel Edge - connected new white constant to output ## Color Correction Adjustment - added gradient as parameter ## Hash Random Vector 2D and Vector2 Compose - added VectorDecompose and VectorCompose to preserve blue value of 1 that was the default in 3.x
Thank you for this! saved me some work though i had another problem. I tried using worley3d with the default values:
I could stop the error from appearing by changing the init func default values to floats.:
looking through the other files it seemed like a random choosing between floats and ints as defaults. Is there a reason someone would want to choose an int as a defaultvalue for a VisualShaderNode.PORT_TYPE_SCALAR? or is it just something i happen to be the first one to notice? |
@thomasgauthier thanks a lot! |
I also had problems with scalar input being treated as ints instead of floats. Changing all relevant inputs to floats explicitly like @Ludmuterol described probably would fix it. I can try this. @arkology I can do the |
…default values to float literals
Just got to this now. 6f5cabf has the |
@thomasgauthier thanks! I'll test it at the weekend and merge into master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly ran through the changes and overall everything looks great! If something is wrong, it can be fixed later, but right now I think it's ready for merge🎉
Thanks! |
Global changes
VisualShaderNode.PORT_TYPE_VECTOR
references toVisualShaderNode.PORT_TYPE_VECTOR_3D
Specific changes
addons/shaderV/tools/random/randomGoldNoiseFloat.gdshader
addons/shaderV/rgba/bloom.gd
addons/shaderV/tools/random/randomGoldNoiseFloat.gd
addons/shaderV/rgba/generate_shapes/scanLinesSharp.gd
addons/shaderV/rgba/generate_shapes/stripesRandom.gd
addons/shaderV/uv/animated/tilingNoffsetAnimated.gd
+=
to=
in generated codeVisual shaders
Sobel Edge
Color Correction Adjustment
Hash Random Vector 2D and Vector2 Compose