Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deepin-loongarch64 libmupdf.so lib and modify build.sh to adapt l… #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GithubXkw1573
Copy link

#linux-loongarch64 support

I Compiled the dependency of libmupdf.a and libmupdf-third.a on loongarch64 GNU/Linux
and then modifed the native/build.sh to support loongarch64

image

and compile and output the libMuPDFWrapper.so, so that can run loongarch64 platform and I have test it run successful !

@arklumpus
Copy link
Owner

Hi, thank you for the contribution! Unfortunately, I don't think I can merge this in the main repository, for two main reasons:

  • Since I do not have access to a loongson CPU, I would not be able to recompile things if I needed to apply any updates.
  • I am also not really comfortable with hosting and distributing binaries that I did not compile personally (especially in the light of recent events, like the XZ Utils backdoor incident).

My advice would be for you to create a separate GitHub repository with the loongarch64 native assets, and upload yourself the MuPDF.NativeAssets.Linux-loongarch64 to NuGet. Note that there are a couple of places in your pull request where Linux-x64 is still referenced rather than Linux-loongarch64 - you should probably fix these. I can then add a note to the main MuPDFCore repository stating that Linux-loongarch64 is unofficially supported thanks to [your repository].

I hope this makes sense, and thank you again for putting the work in this!

@GithubXkw1573
Copy link
Author

GithubXkw1573 commented Jun 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants