Merged
Conversation
-Added two events that trigger after Austria gets dismantled that give the opportunity to Switzerland to annex Vorarlberg (in game Bregenz, province id 614) -Changed the pops of Vorarlberg/Bregenz from South German to Swiss -Added Swiss as accepted culture to AUS/KUK/DNB -Added an event for AUS/KUK/DNB that removes Swiss as accepted if they declare war on Switzerland -Added a decision to Switzerland to get a core on Vorarlberg if they abandon their neutrality
Development
-Changed the Welsh liberal party's end date as Wales after 1859 doesn't have another liberal party
Many country & province history files had mixed (CR/LF together with LF) or inappropriate (i.e. lone CR) line endings. With this change all those files use consistent line endings. Something along the lines of `git diff --ignore-space-at-eol Development` is suggested to review the changes: it’ll take care of the CR/LF noise by hiding all of it. This also goes some way into demonstrating that most changes are intended conversions to native line endings. This should only leave lone CR changes in the diffs to review. (Unless you are a time traveller using classic Mac OS I suppose. Hi!)
-Changed the organize_kenya and organize_tanzania decisions to remove Zanzibar cores only in provinces that the country who takes the decisions owns
-Merged and changed two decisions that gave Selkirk to whomever owns Stikine
The purpose of the `establish_writing_system` decision (typo in the name fixed in this change) is to remove the crippling `lacks_writing_system` modifier when applicable. However the decision is only conditioned on the related `lacking_writing_system` flag and not the modifier itself. Should a country lose the flag in some fashion, it would be stuck with the debilitating modifier for the rest of the game. I don't believe that this status can realistically be achieved in most games, though it is not entirely outside the realm of possibility either. For instance an organised `ARO` (aka Biafra) that managed impossibly high literacy through colonial shenanigans might become eligible for `colonial_legacy` after release. With this change the condition for the `establish_writing_system` decision correctly reflects its effect, namely by targeting the `lacks_writing_system` modifier. On top of that the modifier is also consistently removed whenever the flag is.
…meter graphical glitch To improve the visualization of life rating on the province's screen, the scale of the gfx was reduced by half, with 50 being the maximum. (Using the same trick, it is also possible to show a scale of 0-10 life_rating, which would be better in my opinion, but it is necessary to test effects on migration and pop grow.) A vanilla visual glitch in the needs meter was also fixed. The 'progress.fx' function cuts a line of pixels after processing the sprite, perhaps due to rounding error. Reduced and lightened beer foam, TGA transparency of the wine glass has been corrected.
Welsh liberal party minor fix
* Minor reshape in Burma. Minor flips to state borders to help the AI. * Fix to New Zealand not having a socialist party until late in the game.
Zanzibar cores
The Alaskan Frontier decision
…smeter Gfx life rating visual scale reduced by half and fixed vanilla needs meter graphical glitch
Condition adoption of writing system on modifier
Normalise line endings
…ction National focus mapmode fix
* Fixed to Welsh Liberal party early end date. From #97 by @Libeccio-DD * Tweaks for the Zanzibar cores #101 and Alaskan Frontier decision #102 by @Libeccio-DD * Fixes to the Life Rating visual scale and to several graphics #107 by @thiagodesacosta * Fixes for potential problems if a country was somehow stuck with the lacks_writing_system modifier by @moretrim - #105 * Fix Fort position in Niigata so they do not overlap with Sado. Closes #104 * Fix for Greater Germany events not distributing provinces to existing countries - they will do it now. Made a few tweaks to the order of the released countries. If Austria has Bohemia/Sudetes/Lower Silesia cores when the event fires, Germany should get these as cores (and inherit them). Again, this is all a temporary solution until I fix the mess over Austrian cores. Closes #108 * Changed the requirement for building the Panama canal from the TNT invention to the "Drilling and Blasting" tech to avoid the invention's conditions delaying the construction of the canal. Closes #109 * National focus map mode fix by @Libeccio-DD - #112
Swiss Flavour regarding Vorarlberg
-Changed the population of the Kingdom of Saxony
Closes #114. To sidestep the quirks of `num_of_ports` and spare players the frustration of spuriously invalidated CBs, a different requirement is used instead: any_owned_province = { port = yes } A comment in cb_types lays out the situation in full for future maintainers.
Change naval requirements for CBs
* Cleanup to the Conquest of the Chaco/Desert decisions. They've been opened up to any SP or GP past a certain date if they own the correct provinces/have the right techs. * Small changes to provinces in the Austrian empire to guarantee they do not start with unemployment. * During the Anglo-Sikh war, AI UK-allied countries that are not part of the Indian subcontinent should now drop from the war without prejudice to their alliance with the UK. * Fix to a vanilla bug that could cause CBs to be invalidated depending on armies sieging your capital. By @moretrim - closes #114 via #116 * Fix to a vanilla bug that made newly released countries like Oman, Sudan or CSA that had slavery lose random slave states. Closes #96
* Picking government decisions shouldn't block other players from picking it anymore. Closes #100
* Minor changes to provinces in Anatolia by @Libeccio-DD to better reflect historical borders. Closes #84 * When becoming England, the UK will lose Anglo-Canadian and Australian as accepted. These cultures will also be lost as accepted when these territories are given home rule. * Changed Orissa's colour so it's not exactly the same as Nejd.
* Fort positions fix by @Libeccio-DD - integrates and closes #106
* Changed Perry's expedition localization text to be more clear how to end the war without enforcing the add_to_sphere CB. Included the event chain in the debt system. Slightly decreased the requirements for the decision to be used.
* Changed Kingwana culture colour so it is not similar to Mongo culture.
* Moved "political rights" reform from Political to Social reforms.
* Constitutional-Monarchy Germany should still be called "German Empire".
* Indian minor states should now have the possibility of joining a vassalized India.
* Slight infamy reduction for the "Free Allied Core" CB. Reduced the maximum "Take Puppet" CB infamy to 12.5 from 15.
-Fix to correct the movement icons showing in the population tab
* Removal of all duplicate localization entries between HPM-NNM thanks to the awesome script written by @nappys-legacy. Closes #113
Congo production fix
The Kingdom of Saxony's population
Movement icons fix
* Fix to FCS event chain firing wrong production events by @Libeccio-DD - #120 * Fixes for the population of Saxony by @Libeccio-DD - #115 * Fix for the social/political movements icons by @Libeccio-DD - #121 * Work on normalizing line endings by @moretrim #99 - may need a review since the last round of script-made standardization to the files.
* Made sure the event that informs the player they have the Imperialism CB fires correctly for the Ottomans/Russia.
-Fixed citizen rights showing under social spending and changed the destitution and poverty modifier to use the red icon
Minor fixes
chaotea
pushed a commit
to chaotea/vic2-HPM
that referenced
this pull request
Dec 18, 2022
Release 0.4.6.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.