-
Notifications
You must be signed in to change notification settings - Fork 267
updated Esp32, merged for testing branch #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merged manually again. Hopefully no errors this time. Please test. |
The library seems to work well with ESP32 but for _TASK_SLEEP_ON_IDLE_RUN, the light sleep mode of the ESP32 is not working as expected (by now), disables connectivity and freezes the MCU, so I've actually implemented with a safe delay(1) until further framework updates you can merge now (in testing or even in master) |
Yeah, I ran into similar issues with 8266 - their understanding of a "light" sleep is different from AVR. |
yes is what I did but the process is not the same as for the 8266, in that delay there are some specific features enabled via "user_interface.h" header so the solution is a standard delay or don't use the _TASK_SLEEP_ON_IDLE_RUN feature at all (maybe it is the best option) you can merge and close |
Thank you for your help! |
it is simply and old project based on esp8266 I'm tryng to port to ESP32 |
Cool |
OK. Done with the merge. Should be OK now. |
when will you merge testing to master branch? |
Done |
since the last PR was closed #47 and was intended to merge ESP32 support on master branch
I've issued this new pull resquest to be merged on the testing branch