Skip to content

updated Esp32, merged for testing branch #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

updated Esp32, merged for testing branch #48

wants to merge 10 commits into from

Conversation

baggior
Copy link

@baggior baggior commented Jan 31, 2018

since the last PR was closed #47 and was intended to merge ESP32 support on master branch
I've issued this new pull resquest to be merged on the testing branch

@baggior baggior changed the title updated Esp32, correctly merged for testing branch updated Esp32, merged for testing branch Jan 31, 2018
@arkhipenko
Copy link
Owner

Merged manually again. Hopefully no errors this time. Please test.
Branch: "Testing"

@baggior
Copy link
Author

baggior commented Feb 1, 2018

The library seems to work well with ESP32

but for _TASK_SLEEP_ON_IDLE_RUN, the light sleep mode of the ESP32 is not working as expected (by now), disables connectivity and freezes the MCU, so I've actually implemented with a safe delay(1) until further framework updates

you can merge now (in testing or even in master)

@arkhipenko
Copy link
Owner

Yeah, I ran into similar issues with 8266 - their understanding of a "light" sleep is different from AVR.
We can just use the same process as 8266 for now, no?

@baggior
Copy link
Author

baggior commented Feb 1, 2018

yes is what I did but the process is not the same as for the 8266, in that delay there are some specific features enabled via "user_interface.h" header
and they don't exists for ESP32 (not analogue found)

so the solution is a standard delay or don't use the _TASK_SLEEP_ON_IDLE_RUN feature at all (maybe it is the best option)

you can merge and close

@arkhipenko
Copy link
Owner

Thank you for your help!
If not a secret, what are you using TS for?

@baggior
Copy link
Author

baggior commented Feb 2, 2018

it is simply and old project based on esp8266 I'm tryng to port to ESP32
The MCU is remotely controlling my heatpump and my home room temperatures in a "clever" way

@arkhipenko
Copy link
Owner

Cool

@arkhipenko
Copy link
Owner

OK. Done with the merge. Should be OK now.

@arkhipenko arkhipenko closed this Feb 3, 2018
@baggior
Copy link
Author

baggior commented Feb 6, 2018

when will you merge testing to master branch?

@arkhipenko
Copy link
Owner

Done

@baggior baggior deleted the esp32 branch February 18, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants