fix button size #228

bordalix · 2025-11-13T17:06:26Z

Summary by CodeRabbit

Style
- Refined appearance of Send and Receive buttons in the wallet screen.
Updates
- Updated SDK dependency configuration.
- Adjusted wallet service threshold to 24-hour intervals.

cloudflare-workers-and-pages · 2025-11-13T17:06:36Z

Deploying wallet-signet with Cloudflare Pages

Latest commit:	`655c838`
Status:	✅ Deploy successful!
Preview URL:	https://53358fd2.wallet-23u.pages.dev
Branch Preview URL:	https://fix-button-size.wallet-23u.pages.dev

View logs

coderabbitai · 2025-11-13T17:06:40Z

Walkthrough

The changes update the arkade-os SDK dependency to a local workspace reference, modify a performance fingerprinting threshold from percentage-based to millisecond duration (24 hours), and add a new main boolean prop to Button and FlexRow components to conditionally apply minHeight styling.

Changes

Cohort / File(s)	Summary
Dependency management `package.json`	Updated "@arkade-os/sdk" dependency from version "0.3.5" to local file reference "file:../ts-sdk"
Configuration update `public/wallet-service-worker.mjs`	Replaced `thresholdPercentage` with `thresholdMs` property in fp.config; set to 1440 * 60 * 1e3 (24 hours)
Component prop threading `src/components/Button.tsx`, `src/components/FlexRow.tsx`	Added `main?: boolean` prop to ButtonProps and FlexRowProps; implemented conditional minHeight styling in FlexRow (20px when main is true); Button passes prop through to FlexRow
Component usage `src/screens/Wallet/Index.tsx`	Updated two Button component usages (Send and Receive actions) to pass `main` prop

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

These are straightforward prop additions and dependency updates with no complex logic changes
Consistent pattern of threading a new prop through the component hierarchy
Primary focus areas: verify the 24-hour threshold calculation is correct and ensure the main prop styling behavior aligns with UI design intent

Possibly related PRs

fix send/receive subdust #201: Both PRs modify the "@arkade-os/sdk" dependency declaration in package.json

Suggested reviewers

louisinger

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix button size' directly corresponds to the main changes in the PR, which add a main prop to Button and FlexRow components to conditionally apply minHeight styling.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix_button_size

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2025-11-13T17:06:58Z

Deploying wallet-mutinynet with Cloudflare Pages

Latest commit:	`655c838`
Status:	✅ Deploy successful!
Preview URL:	https://4074b6b3.arkade-wallet.pages.dev
Branch Preview URL:	https://fix-button-size.arkade-wallet.pages.dev

View logs

cloudflare-workers-and-pages · 2025-11-13T17:07:17Z

Deploying wallet-bitcoin with Cloudflare Pages

Latest commit:	`655c838`
Status:	✅ Deploy successful!
Preview URL:	https://3a1b5b25.wallet-bitcoin.pages.dev
Branch Preview URL:	https://fix-button-size.wallet-bitcoin.pages.dev

View logs

Copilot

Pull Request Overview

This PR addresses button sizing issues by introducing a new main prop that sets a minimum height on buttons. The changes also include an unrelated update to the SDK dependency and service worker configuration.

Added main prop to Button and FlexRow components to control minimum height
Updated @arkade-os/sdk dependency to use a local file reference
Changed service worker configuration from thresholdPercentage to thresholdMs

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/screens/Wallet/Index.tsx	Added `main` prop to Send and Receive buttons
src/components/FlexRow.tsx	Added `main` prop to set minimum height of 20px
src/components/Button.tsx	Added `main` prop and passed through to FlexRow component
public/wallet-service-worker.mjs	Changed threshold configuration from percentage to milliseconds (24 hours)
pnpm-lock.yaml	Updated lockfile to reflect local SDK dependency
package.json	Changed SDK dependency to local file reference

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

package.json

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/components/Button.tsx (1)

48-60: Pass main prop consistently to FlexRow in all branches, or document why certain branches exclude it.

The main prop controls minHeight: 20px in FlexRow (FlexRow.tsx line 43), but it's only passed to FlexRow in the default branch (Button.tsx line 57). The fancy and loading branches ignore this prop, creating inconsistent behavior where <Button main fancy /> would silently discard the main prop. Either pass main to all FlexRow instances (lines 46, 49, 57) or explicitly design fancy/loading branches to not support the prop.

🧹 Nitpick comments (1)

src/components/Button.tsx (1)

13-13: Consider a more descriptive prop name.

The prop name main doesn't clearly convey that it controls minimum height. Consider names like ensureMinHeight, fixedHeight, or withMinHeight for better code clarity.

Also applies to: 28-28

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0fad3f and 5c5c811.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (5)

package.json (1 hunks)
public/wallet-service-worker.mjs (1 hunks)
src/components/Button.tsx (3 hunks)
src/components/FlexRow.tsx (3 hunks)
src/screens/Wallet/Index.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📚 Learning: 2025-07-21T18:25:36.391Z

Learnt from: bordalix
Repo: arkade-os/wallet PR: 121
File: src/screens/Init/Restore.tsx:58-58
Timestamp: 2025-07-21T18:25:36.391Z
Learning: In src/screens/Init/Restore.tsx, the Input component for private key restoration intentionally omits the `value` prop to make it uncontrolled. This is a security feature to prevent the private key from being displayed if users navigate away and return to the screen, avoiding potential exposure of sensitive data in the UI.

Applied to files:

src/screens/Wallet/Index.tsx

📚 Learning: 2025-06-30T18:33:29.839Z

Learnt from: bordalix
Repo: arkade-os/wallet PR: 114
File: src/lib/asp.ts:0-0
Timestamp: 2025-06-30T18:33:29.839Z
Learning: In src/lib/asp.ts, only the collaborativeExit function should accept both IWallet and ServiceWorkerWallet types. Other wallet functions (getBalance, getTxHistory, getReceivingAddresses, redeemNotes, sendOnChain, settleVtxos) should maintain their original IWallet-only signatures and not be updated for consistency.

Applied to files:

src/screens/Wallet/Index.tsx
public/wallet-service-worker.mjs

📚 Learning: 2025-06-30T18:23:34.163Z

Learnt from: bordalix
Repo: arkade-os/wallet PR: 114
File: public/wallet-service-worker.mjs:6350-6353
Timestamp: 2025-06-30T18:23:34.163Z
Learning: Do not review `public/wallet-service-worker.mjs` as it is a built file generated by Vite.

Applied to files:

public/wallet-service-worker.mjs

🧬 Code graph analysis (2)

src/screens/Wallet/Index.tsx (1)

src/components/Button.tsx (1)

Button (21-64)

src/components/Button.tsx (1)

src/components/FlexRow.tsx (1)

FlexRow (17-48)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Agent

🔇 Additional comments (3)

public/wallet-service-worker.mjs (1)

8811-8813: Built artifact: skipping review per repository policy.

This file is a Vite-generated bundle. Please review and make changes in the source modules that produce this code (e.g., where FP/thresholdMs is defined) and ensure the build pipeline reflects the intended 24h (1440601e3) behavior.

src/screens/Wallet/Index.tsx (1)

54-55: LGTM! Consistent application of the new main prop.

The main prop is correctly applied to both Send and Receive buttons, ensuring consistent sizing across the wallet action buttons.

src/components/FlexRow.tsx (1)

12-12: LGTM! Clean implementation of conditional minHeight.

The main prop is correctly added to the interface and component, and the conditional minHeight styling is properly applied. The 20px value provides a reasonable minimum height for buttons.

Also applies to: 26-26, 39-39

package.json

* fix button size * fix

* use thresholdMs + fix coin control * update dependencies * fix * Add aspInfo and svcWallet to the dependency array * fix * Prevent async rollover updates from stomping newer wallet stat * fix button size (#228) * fix button size * fix * fix UI * improvements

fix button size

5c5c811

bordalix requested a review from Copilot November 13, 2025 17:06

Copilot started reviewing on behalf of bordalix November 13, 2025 17:06 View session

Copilot finished reviewing on behalf of bordalix November 13, 2025 17:08

fix

655c838

Copilot AI reviewed Nov 13, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

coderabbitai bot reviewed Nov 13, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

bordalix merged commit f5694a5 into master Nov 13, 2025
6 checks passed

bordalix added a commit that referenced this pull request Nov 13, 2025

fix button size (#228)

61f10b7

* fix button size * fix

coderabbitai bot mentioned this pull request Nov 14, 2025

Fix coin control #229

Merged

bordalix deleted the fix_button_size branch November 26, 2025 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix button size #228

fix button size #228

Uh oh!

bordalix commented Nov 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix button size #228

fix button size #228

Uh oh!

Conversation

bordalix commented Nov 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

cloudflare-workers-and-pages bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying wallet-signet with Cloudflare Pages

Uh oh!

coderabbitai bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

cloudflare-workers-and-pages bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying wallet-mutinynet with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying wallet-bitcoin with Cloudflare Pages

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bordalix commented Nov 13, 2025 •

edited by coderabbitai bot

Loading

cloudflare-workers-and-pages bot commented Nov 13, 2025 •

edited

Loading

coderabbitai bot commented Nov 13, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 13, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 13, 2025 •

edited

Loading