-
Notifications
You must be signed in to change notification settings - Fork 13
new app card #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new app card #220
Conversation
WalkthroughAdded a boolean Changes
Sequence Diagram(s)sequenceDiagram
participant Apps as Apps/Index
participant Shadow as Shadow component
Apps->>Shadow: render(app, props... , borderPurple = live)
alt live == true
Note right of Shadow: borderPurple=true\nchoose var(--purple) border
else live == false
Note right of Shadow: borderPurple=false\nchoose var(--dark10) border
end
Shadow-->>Apps: renders children with computed border color
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/Shadow.tsx(3 hunks)src/screens/Apps/Index.tsx(4 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/screens/Apps/Index.tsx (3)
src/components/Bullet.tsx (1)
Bullet(1-12)src/components/FlexRow.tsx (1)
FlexRow(16-45)src/components/Shadow.tsx (1)
Shadow(18-55)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (4)
src/components/Shadow.tsx (1)
5-5: LGTM! Clean conditional border styling.The
borderPurpleprop is well-integrated and follows the existing pattern. The conditional logic clearly switches between purple and dark10 border colors based on the prop value.Also applies to: 20-20, 42-42
src/screens/Apps/Index.tsx (3)
21-44: LGTM! Tag component refactoring looks good.The updated styling and layout effectively differentiate between 'new' and 'coming soon' states. The use of FlexRow with the Bullet component for 'new' items provides a clear visual indicator, and the non-breaking space ensures "coming soon" displays correctly.
55-91: LGTM! App component updates enhance the UI.The added padding improves the clickable area, and the
borderPurple={live}prop correctly ties the border styling to the app's live status, creating a cohesive visual design with the Tag component.
93-132: LGTM! App status indicators are correctly configured.The
liveprop is appropriately set for active apps (Boltz, LendaSat, LendaSwap), while Fuji Money correctly defaults to "coming soon" status. The visual hierarchy effectively communicates app availability.
Deploying wallet-signet with
|
| Latest commit: |
ea0897c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2775e81e.wallet-23u.pages.dev |
| Branch Preview URL: | https://app-card.wallet-23u.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/screens/Apps/Index.tsx (1)
37-42: Consider using<span>instead of<p>for inline text.The
<p>element typically has default vertical margins that could interfere with the tight layout inside FlexRow. Since this is inline text within a flex container, a<span>would be more appropriate.Apply this diff:
<div style={style}> <FlexRow centered gap='0.25rem'> {kind === 'new' ? <Middot /> : ''} - <p>{kind.replace(' ', '\u00A0')}</p> + <span>{kind.replace(' ', '\u00A0')}</span> </FlexRow> </div>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/screens/Apps/Index.tsx(4 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/screens/Apps/Index.tsx (2)
src/components/FlexRow.tsx (1)
FlexRow(16-45)src/components/Shadow.tsx (1)
Shadow(18-55)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (4)
src/screens/Apps/Index.tsx (4)
15-19: LGTM! Accessibility and naming concerns addressed.The
aria-hidden='true'attribute has been properly added, and the component has been renamed from "Bullet" to "Middot" to avoid collision withsrc/components/Bullet.tsx. The implementation is correct.
60-60: LGTM!The padding addition improves the visual spacing of the app card container.
69-69: LGTM!The
borderPurpleprop correctly wires the live state to the Shadow component's border styling, applying a purple border for live apps and a dark border otherwise.
77-77: LGTM!The conditional logic correctly displays the 'new' tag for live apps and 'coming soon' for others, aligning with the updated visual design.
Deploying wallet-mutinynet with
|
| Latest commit: |
ea0897c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5425909f.arkade-wallet.pages.dev |
| Branch Preview URL: | https://app-card.arkade-wallet.pages.dev |
Deploying wallet-bitcoin with
|
| Latest commit: |
ea0897c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ce8deee.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://app-card.wallet-bitcoin.pages.dev |
Small UI fixes in App cards
Before:
After:
Summary by CodeRabbit
New Features
Style