Conversation
Deploying wallet-signet with
|
| Latest commit: |
e24d7d9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62b818f5.wallet-23u.pages.dev |
| Branch Preview URL: | https://boltz-urls.wallet-23u.pages.dev |
|
Caution Review failedThe pull request is closed. WalkthroughRemoved exported Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Env as Environment (VITE_BOLTZ_URL)
participant BASE as BASE_URLS
participant LP as LightningProvider
note right of Env #eef2ff: Build-time/env lookup
Env->>BASE: provide optional VITE_BOLTZ_URL
BASE->>LP: supply baseUrl for aspInfo.network (bitcoin/signet/regtest)
alt baseUrl present
LP->>LP: initialize provider with baseUrl
else no baseUrl
LP->>LP: early return / no provider initialized
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying wallet-mutinynet with
|
| Latest commit: |
be5bcbe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ea450e76.arkade-wallet.pages.dev |
| Branch Preview URL: | https://boltz-urls.arkade-wallet.pages.dev |
Deploying wallet-bitcoin-v8 with
|
| Latest commit: |
be5bcbe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1bffae33.wallet-v8.pages.dev |
| Branch Preview URL: | https://boltz-urls.wallet-v8.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/providers/lightning.tsx (1)
10-10: LGTM! Good practice for production configurability.The environment variable support allows runtime configuration of the Boltz URL for the bitcoin network, with a sensible fallback to maintain backward compatibility.
Consider documenting the
VITE_BOLTZ_URLenvironment variable in the project's README or environment configuration guide for easier deployment setup.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/lib/constants.ts(0 hunks)src/providers/lightning.tsx(2 hunks)src/screens/Wallet/Receive/QrCode.tsx(0 hunks)
💤 Files with no reviewable changes (2)
- src/lib/constants.ts
- src/screens/Wallet/Receive/QrCode.tsx
🔇 Additional comments (1)
src/providers/lightning.tsx (1)
45-46: LGTM! Clean implementation with proper safety check.The direct usage of
BASE_URLSwith a type cast is safe because line 46 properly handles the case where the network is not supported. The provider creation will be skipped gracefully for unsupported networks.
| bitcoin: import.meta.env.VITE_BOLTZ_URL ?? 'https://boltz-v8.arkade.sh', | ||
| mutinynet: 'https://boltz.mutinynet.arkade.sh', | ||
| testnet: 'https://boltz.testnet.arkade.sh', | ||
| signet: 'https://boltz.signet.arkade.sh', |
There was a problem hiding this comment.
🧩 Analysis chain
Verify the testnet network removal doesn't break existing deployments.
The addition of signet network support is good. However, according to the AI summary, testnet was replaced with signet. Ensure that no existing deployments or configurations rely on the testnet network type.
Run the following script to check for any testnet references:
🏁 Script executed:
#!/bin/bash
# Description: Search for testnet references in the codebase to ensure removal doesn't break functionality
# Search for testnet network references
echo "=== Searching for 'testnet' references ==="
rg -n --type=ts --type=tsx -i 'testnet' -C 2
# Search for Network type definition to see all valid network values
echo -e "\n=== Searching for Network type definition ==="
ast-grep --pattern 'type Network = $_'
ast-grep --pattern 'enum Network { $$$ }'
# Check if aspInfo.network can return 'testnet'
echo -e "\n=== Checking aspInfo network assignments ==="
rg -n --type=ts --type=tsx 'network.*=.*testnet' -C 2Length of output: 191
🏁 Script executed:
#!/bin/bash
echo "=== Searching for 'testnet' references ==="
rg -n -C2 -i 'testnet' -- '*.ts' '*.tsx'
echo -e "\n=== Searching for Network type definition ==="
rg -n -C2 'type\s\+Network\s*=' -- '*.ts' '*.tsx'
rg -n -C2 'enum\s\+Network' -- '*.ts' '*.tsx'
echo -e "\n=== Checking aspInfo.network assignments ==="
rg -n -C2 'aspInfo\.network\s*=\s*["'"'"']testnet["'"'"']' -- '*.ts' '*.tsx'Length of output: 499
🏁 Script executed:
#!/bin/bash
echo "=== Searching for 'testnet' references ==="
rg -n -C2 -i 'testnet' -g '*.ts' -g '*.tsx'
echo -e "\n=== Searching for Network type definition ==="
rg -n -C2 'type\s\+Network\s*=' -g '*.ts' -g '*.tsx'
rg -n -C2 'enum\s\+Network' -g '*.ts' -g '*.tsx'
echo -e "\n=== Checking aspInfo.network assignments ==="
rg -n -C2 'aspInfo\.network\s*=\s*["'"'"']testnet["'"'"']' -g '*.ts' -g '*.tsx'Length of output: 827
Address inconsistent network mappings for testnet and signet
src/lib/explorers.ts still defines and uses testnet endpoints (lines 24–27, 45–46), but lightning.tsx now replaces testnet with signet. This mismatch will break testnet flows—either re-add testnet support in the provider or update explorers.ts (and the Network type) to handle signet.
1 participant
@tiero please review
Summary by CodeRabbit
New Features
Chores
Refactor