show an error if ln invoice has no amount #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughA validation was added to the recipient input logic in the Send form to check for the presence of a non-zero amount in pasted Lightning invoices. If the invoice lacks a defined amount or specifies zero, an error message is set and further processing is halted, preventing the user from continuing. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SendForm
participant InvoiceParser
User->>SendForm: Paste Lightning invoice
SendForm->>InvoiceParser: Parse invoice
InvoiceParser-->>SendForm: Return satoshis amount
alt Amount undefined or zero
SendForm->>User: Display error "Invoice must have amount defined"
SendForm-->>User: Prevent continue
else Amount valid
SendForm->>User: Allow continue
end
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (3)📚 Learning: in src/lib/bolt11.ts, the code is copied from the original bitcoinjs/bolt11 library (https://github....Applied to files:
📚 Learning: in src/lib/asp.ts, only the collaborativeexit function should accept both iwallet and serviceworkerw...Applied to files:
📚 Learning: in src/screens/init/restore.tsx, the input component for private key restoration intentionally omits...Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying wallet-for-riga with
|
| Latest commit: |
abfc20e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eacf9c8f.wallet-23u.pages.dev |
| Branch Preview URL: | https://invoice-no-amount.wallet-23u.pages.dev |
Deploying arkade-wallet with
|
| Latest commit: |
abfc20e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2be1115.arkade-wallet.pages.dev |
| Branch Preview URL: | https://invoice-no-amount.arkade-wallet.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #135
Summary by CodeRabbit