support for subdust output in ark tx #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bordalix
approved these changes
Jun 26, 2025
louisinger
added a commit
that referenced
this pull request
Jul 11, 2025
* add arknote tests * refactor arknote to v7 * make hrp a optional constructor variable * refactor tests to test hrp * update ci to work next-version branch * add arknote integration test (#75) * BIP322 Intents (#77) * BIP322 intent * also return message in the intents methods * new round flow (#78) setup test to target next-version branch hotfix note in registerInputsForNextRound fix signingSession.ts * nit: better test instructions (#82) * nit: better test instructions * fix ci * Intent registration (#80) * new round flow setup test to target next-version branch hotfix note in registerInputsForNextRound fix signingSession.ts * use BIP0322 to register intent * ArkNote implements ExtendedCoin * allow all sighash types * remove registerOutputsForNextRound API * offchain transaction w/ checkpoints (#84) * new round flow setup test to target next-version branch hotfix note in registerInputsForNextRound fix signingSession.ts * use BIP0322 to register intent * implement checkpoints * update examples * fix register message * fix tx history (#89) * Support recoverable vtxos (#88) * support recoverable vtxos * update ci.yml * fixes * update e2e test * Drop explorer for indexer (#83) * drop explorer for indexer * remove console.log * fix on returned vtxos * Update src/providers/ark.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> * separates indexer to own provider * private method createSubscription * implements all methods on indexer provider * remove console.logs * fix build error * add opts to indexer methods * remove not needed export * remove getRound() from ark provider * cleanup ProtoTypes in ark provider * fix export of RestIndexerProvider * refactor indexer to use namespace * adds type guards * fixes * new test * Merge branch 'next-version' into drop_explorer_for_indexer * remove console.log * use paginationOptions * more tests * bug fix * activate tx history test * forfeit address * make methods name lowercase * update endpoints * move indexer tests to indexer.test.ts * update to latest APIs * freeze test on commit deca5ef4699037dcc38a320e50478fc3eae957ec * lint * new util functions to create vtxos * fixes with content-type * new subscribeForScripts test * fix tests --------- Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: louisinger <louis@vulpem.com> * support for subdust vtxo in ark tx (#98) * add checkpointTapLeafScript in VirtualTxInput (#101) * Rework ark psbt fields (#105) * rework ark psbt fields * use constant as key.type * fix decode * TxGraph, new address and pub/sub (#100) * add tx graph, remove tx tree class * fix signingSession.ts and txGraph.ts * new address encoding * compatibilty with arkd next-version * rename and move unilateral exit e2e test * update examples * update README.md * update README.md * add e2e test case * update index.ts * fixes indexer.go * cleaning validation.go * renaming tests * Remove onchain wallet from `Wallet`, add `OnchainWallet` class (#102) * add OnchainWallet class * "send" --> "sendBitcoin" * update WalletBalance * fix src/index.ts * fix ark.test.ts * update README * remove network from WalletConfig * test on 783ba19512f0ddf87962a558576acc9389d0bd7e arkd * fix serviceWorker/wallet.ts * cleaning * update WalletBalance * get dust amount from server * remove getAddressInfo * getAddress & getBoardingAddress * update README * update tests * update test/e2e/utils.ts * Update to latest next-version arkd (#112) * update to latest next-version arkd * add more e2e indexer tests * server.Dockerfile: test on next-version * skip failing tests * ServiceWorkerWallet implements Identity (#114) * ServiceWorkerWallet implements Identity * fix error message * fix tests after arkd v0.7 (#118) * Unilateral exit v7 (#115) * add AnchorBumper interface and rework exit (renamed "unroll") * unilareral exit v7 * update README * Update src/wallet/wallet.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> * Update src/wallet/wallet.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> * fix selectcoins * Revert "fix selectcoins" This reverts commit 9a52311. * cleaning coinselect.ts * clean * remove hardcoded 600 sats, add "forceChange" boolean in selectCoins * handle undefined getFeeRate * use blocks/tip endpoint * Unroll namespace * Update src/wallet/unroll.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> * Update src/wallet/unroll.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> * ark.test.ts: switch case * add compleUnroll function, remove it from Wallet interface --------- Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add Ramps class (#119) * Update README.md Signed-off-by: Marco Argentieri <3596602+tiero@users.noreply.github.com> * Update to latest arkd, renaming and TSDoc (#108) * renaming * remove unused imports * update names, JSDocs * update index.ts * remove unused dev deps * remove "lint-staged" * add "arkade" keyword to pkg.json * TSDoc * add TSDoc generation * add tsdoc.yml workflow * remove upload * use pnpm docs:build * fix * trigger TSDoc deploy on next-version and master push * Update .github/workflows/tsdoc.yml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> * update to master (v0.7.0-rc2) * update tsdoc.yml * rename "chunk" to "node" * rename InMemoryKey -> SingleKey --------- Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * tsdoc.yml: trigger on version tag * update README.md * add Wallet.NotifyIncomingFunds method (#95) * new notifyIncomingFunds method on onchain provider * track multi addresses * ignore error * new util function faucetOnchain() * new wallet method notifyIncomingFunds() * tests: make sure there was a notification * Uses built in WebSocket instead of isomorphic-ws Adds new stopFunc() in callback for notifyIncomingFunds New tests on the WebSocket * remove console.log * polyfill WebSocket for github tests * Update src/providers/onchain.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> * new waitForIncomingFunds() func * fix readme * Update src/wallet/wallet.ts Co-authored-by: louisinger <41042567+louisinger@users.noreply.github.com> Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> * Update src/wallet/wallet.ts Co-authored-by: louisinger <41042567+louisinger@users.noreply.github.com> Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> * make waitForIncomingFunds a utils function * Update src/providers/onchain.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> * Update test/e2e/ark.test.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> * update src/utils/waitForIncomingFunds.ts * lint * update readme * Handle missing outputs gracefully instead of throwing errors * Fix variable naming and incorrect property access. * Improve WebSocket URL construction robustness * fix test * fix test * refactor notifyIncomingFunds to return stopFunc * refactor esplora tests * Update README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> * Update src/utils/waitForIncomingFunds.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> * Fix the infinite loop that prevents the method from returning * fix docker files * fix docker-compose.yml * add VERSION to dockerfile * skip "should redeem a note" test * fix note test * remove watchAddresses test * remove "ws" devDeps * remove testing purpose only interface parameter * do not export unused types * Update src/providers/onchain.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> * remove setup-polyfill * fix * fallback to polling if WebSocket not available * fix test * fix test * update README * add SubscriptionResponse to index.ts exports * remove MockWebSocket * remove extra blanck line * revert vitest.config.ts --------- Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: louisinger <41042567+louisinger@users.noreply.github.com> Co-authored-by: louisinger <louis@vulpem.com> * add tsdoc comments (#120) * handle FetchTimeout in new streaming functions * remove duplicated code * CI: run down to delete dev env * freeze test on v0.7.0 tag * update examples * Dockerfiles: use tag to checkout v0.7.0 * remove useless docker env vars * rename virtualTx -> arkTx * fix capture ark logs in CI * add sleep to indexer.test.ts * arkade wallet hotfix --------- Signed-off-by: João Bordalo <bordalix@users.noreply.github.com> Signed-off-by: louisinger <41042567+louisinger@users.noreply.github.com> Signed-off-by: Marco Argentieri <3596602+tiero@users.noreply.github.com> Co-authored-by: João Bordalo <bordalix@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Marco Argentieri <3596602+tiero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for sending subdust VTXOs in ark transactions. It also includes a new e2e test.
it closes #71
@Kukks @bordalix please review