Skip to content

Conversation

@bordalix
Copy link
Contributor

@bordalix bordalix commented Oct 19, 2025

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain version to 1.25.3 across build environments.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 19, 2025

Walkthrough

Go base image updated from version 1.25.1 to 1.25.3 in the builder stage of two Dockerfiles. No behavioral changes to build steps or logic.

Changes

Cohort / File(s) Summary
Go version update in Docker builder stage
server.Dockerfile, wallet.Dockerfile
Base image bumped from golang:1.25.1 to golang:1.25.3 in builder stage

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • arkade-os/ts-sdk#143: Modifies the same Dockerfiles with base image/version changes in builder stage

Suggested reviewers

  • altafan

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "update golang image version in dockerfiles" accurately and directly describes the main change in the changeset. According to the raw_summary, both server.Dockerfile and wallet.Dockerfile had their base image updated from golang:1.25.1 to golang:1.25.3, with no other behavioral changes. The title is concise, specific, and clearly identifies what is being changed (golang image version), where (dockerfiles), and the action (update). The title avoids vague language and noise, making it easy for teammates to understand the primary change at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch make_tests_pass

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c75f71a and 7ece44c.

📒 Files selected for processing (2)
  • server.Dockerfile (1 hunks)
  • wallet.Dockerfile (1 hunks)
🔇 Additional comments (2)
wallet.Dockerfile (1)

2-2: Consistent version update across Dockerfiles.

The patch version bump to Go 1.25.3 is consistent with the update in server.Dockerfile, confirming a coordinated toolchain upgrade.

server.Dockerfile (1)

2-2: Go 1.25.3 upgrade is approved and beneficial.

Go 1.25.3 is a security-patch release that fixes multiple vulnerabilities including the HTTP/2 resource-exhaustion DoS (CVE-2023-44487) and issues across net/http, crypto, encoding, and mail parsing. The patch-level bump from 1.25.1 is safe and improves the security posture of both builder stages.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tiero tiero merged commit c92a1e7 into master Oct 19, 2025
2 checks passed
tiero added a commit that referenced this pull request Oct 19, 2025
Co-authored-by: João Bordalo <bordalix@users.noreply.github.com>
tiero added a commit that referenced this pull request Oct 19, 2025
Co-authored-by: João Bordalo <bordalix@users.noreply.github.com>
tiero added a commit that referenced this pull request Oct 19, 2025
* return ExtendedVirtualCoin with createdAt as Date

* update golang image version in dockerfiles (#202) (#204)

Co-authored-by: João Bordalo <bordalix@users.noreply.github.com>

---------

Co-authored-by: Marco Argentieri <3596602+tiero@users.noreply.github.com>
tiero added a commit that referenced this pull request Oct 19, 2025
* run this instead of  wallet.getTransactionHistory()

* update golang image version in dockerfiles (#202) (#203)

Co-authored-by: João Bordalo <bordalix@users.noreply.github.com>

---------

Co-authored-by: Marco Argentieri <3596602+tiero@users.noreply.github.com>
@louisinger louisinger deleted the make_tests_pass branch December 29, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants