SubmitOffchainTx: prevent multiple opreturn outputs

[louisinger]

it closes #652

@altafan please review

Summary by CodeRabbit

• Bug Fixes
  • Improved transaction validation by ensuring that transactions with multiple OP_RETURN outputs are rejected with a clear error message.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• next-version

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new validation has been added to the SubmitOffchainTx method, introducing a check for multiple OP_RETURN outputs in transaction outputs. If more than one OP_RETURN output is detected, the function returns an error, ensuring only a single OP_RETURN output is allowed per transaction.

Changes

File(s)	Change Summary
server/internal/core/application/service.go	Added logic to track and reject transactions with multiple OP_RETURN outputs in SubmitOffchainTx.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Service
    participant TxValidator

    Client->>Service: SubmitOffchainTx(tx)
    Service->>TxValidator: Validate outputs
    TxValidator-->>Service: Detects OP_RETURN outputs
    alt Multiple OP_RETURN outputs
        Service-->>Client: Return error "invalid tx, multiple op return outputs"
    else Valid OP_RETURN count
        Service-->>Client: Proceed with transaction processing
    end

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Disallow multiple OP_RETURN outputs in Ark tx (#652)	✅

Poem

In the land of code, a rabbit hops,
Guarding OP_RETURN so error never pops.
Only one shall pass, no more in the mix,
Or the server will shout, "This Ark tx can't fix!"
With every hop, the rules are tight,
One OP_RETURN makes the ledger right. 🐇✨

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[louisinger]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[altafan]

will be reopened after the refactor