This repository has been archived by the owner on May 30, 2023. It is now read-only.
Set frameName for WebPage's resource callbacks. #11373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add frameName to the hash passed to the following callbacks:
* onResourceRequested
* onResourceReceived (both "start" and "end")
* onResourceError
|
It's probably a good idea to create a fresh issue to serve as an umbrella for all |
|
It's likely safer to guard Also, some minimalistic testing in the spec will be good. |
|
Just to be perfectly clear, we've been hit by random crashes in the past because null |
| @@ -251,6 +252,9 @@ QNetworkReply *NetworkAccessManager::createRequest(Operation op, const QNetworkR | |||
| if (op == QNetworkAccessManager::PostOperation) data["postData"] = postData.data(); | |||
| data["time"] = QDateTime::currentDateTime(); | |||
|
|
|||
| QWebFrame *frame = qobject_cast<QWebFrame *>(request.originatingObject()); | |||
| data["frameName"] = frame->frameName(); | |||
There was a problem hiding this comment.
It's important to check for NULL. Or it's going to get ugly here.
Same for the similar code below.
|
I think this needs to be merged with this: #11371 |
vitallium
force-pushed
the
master
branch
2 times, most recently
from
b3cd914
to
c4df640
Compare
vitallium
force-pushed
the
master
branch
2 times, most recently
from
573e969
to
b483dd6
Compare
vitallium
force-pushed
the
master
branch
2 times, most recently
from
1842ba8
to
842715b
Compare
vitallium
force-pushed
the
master
branch
2 times, most recently
from
e024f31
to
5d99f2a
Compare
ghost
merged commit 
Closed
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add frameName to the hash passed to the following callbacks: