Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.
This repository was archived by the owner on May 30, 2023. It is now read-only.

Critical issue in feature for capturing content of responses #13908

@vitallium

Description

@vitallium

Recently I saw very similar issues about weird behaviour with AJAX requests.
After a small investigation I've discovered that NetworkReplyProxy (and NetworkReplyTracker) are the real source of the problems.

The problem:
Wrapping all network requests has the real impact on how WebKit processses network requests (even inside the context of the WebPage!). For example, synchronous AJAX requests don't work. Unfortunately, I didn't dig deep inside into. But the problem is that Webkit waits forever for sync requests (or sometimes for async requests too), so they will be never completed.

Affected issues (still collecting them):
jejacks0n/teaspoon#435
#13891
#13881
#13806 (not sure about this one)
#13805 (yes, memory usage is affected too)
#13788
#11195

Proposal solution: revert all commits with this feature (PR is ready, just give me a green light)

/cc @ariya @zackw @JamesMGreene

Metadata

Metadata

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions