docs(spec): add lightweight logger interface specification #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace Husky with Lefthook as primary hook manager - Add Lefthook configuration file with pre-commit and prepare-commit-msg hooks - Update init command to support Lefthook installation and auto-detection - Add comprehensive Lefthook example with README and configuration - Reorganize examples with global-install and lint-staged+Lefthook integrations - Update .gitattributes to enforce LF line endings for lefthook.yml - Modify documentation to reflect Lefthook as default hook manager 🤖 Generated with Claude via commitment
- Add interactive flag to prepare-commit-msg hook - Allow commitment CLI to interact with user during commit - Ensures proper terminal access for AI agent prompts 🤖 Generated with Claude via commitment
- Define Logger interface with debug/info/warn/error methods
- Specify ConsoleLogger and SilentLogger implementations
- Detail dependency injection flow across all layers
- Establish migration strategy from existing { warn } pattern
- Include architecture compliance and acceptance criteria
🤖 Generated with Claude via commitment
- Add FR7 to fix lefthook.yml hook bug for user-provided messages
- Document root cause: missing `{2}` parameter check in prepare-commit-msg
- Add fix to check commit source before running commitment CLI
- Include verification criteria for git commit -m and merge commits
- Update migration strategy with hook fix implementation details
🤖 Generated with Claude via commitment
- Define 4-task plan with 3 sequential/parallel phases - Break down logger foundation, integration, and documentation tasks - Include complexity estimates (13h parallel vs 19h sequential) - Specify acceptance criteria and quality gates for each task - Map constitutional patterns and TDD requirements 🤖 Generated with Claude via commitment
Owner
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Nov 3, 2025
- Add Logger interface with debug, info, warn, and error methods - Implement ConsoleLogger with chalk-based colored output (gray for debug, yellow for warn, red for error) - Implement SilentLogger for testing and quiet mode - Export logger utilities from utils module - Add comprehensive tests with 132 lines covering both implementations and type compatibility - Configure biome to allow console usage in logger.ts 🤖 Generated with Claude via commitment
[claude] Checking CLI availability [claude] CLI is available [claude] Executing command [claude] Command executed, output length: 599 [claude] Cleaning response [claude] Response cleaned, length: 547 [claude] Validating response format [claude] Response validated successfully feat: integrate logger interface into agent system - Add logger injection to BaseAgent constructor for debugging support - Update agent factory to accept and propagate logger to agent instances - Add debug logging at key lifecycle points in BaseAgent.generate() - Update all BaseAgent subclasses in tests to pass logger via constructor - Modify Generator to use logger interface instead of inline warn function - Update CLI to instantiate ConsoleLogger for generator configuration - Add optional logger property to Agent interface type definition 🤖 Generated with Claude via commitment
refactor: integrate logger interface throughout CLI layer - Replace direct console.log/error calls with logger interface in CLI entry point - Pass logger instances to helper functions (displayStagedChanges, displayGenerationStatus, displayCommitMessage, executeCommit) - Create logger in main command based on --quiet flag (ConsoleLogger vs SilentLogger) - Update init command to always use ConsoleLogger (never quiet) - Simplify helper unit tests to use SilentLogger instead of mocking console - Update checkGitStatusOrExit to use logger.warn/info instead of console 🤖 Generated with Claude via commitment
- Add logger parameter to ChatGPTAgent, MetaEvaluator, and SingleAttemptEvaluator constructors - Pass logger through EvalRunner and AttemptRunner to dependent components - Update all test files to inject SilentLogger into evaluator and runner instances - Update run-eval.ts to instantiate EvalRunner with ConsoleLogger - Remove direct console.log calls in favor of logger interface pattern 🤖 Generated with Claude via commitment
Implements:
- Updated prepare-commit-msg hook to check {2} parameter
- Hook only runs commitment when {2} is empty (regular commits)
- Preserves messages for git commit -m and merge commits
- Updated hook to use commands instead of jobs for consistency
- Added explanatory comments matching example hooks
Acceptance criteria met:
✅ lefthook.yml checks {2} parameter before running commitment
✅ git commit generates message (hook runs)
✅ git commit -m "test" preserves message (hook skips)
✅ Merge commits preserve messages (hook skips)
✅ commitment dogfooding still works
✅ Examples already correct (no changes needed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(spec): add lightweight logger interface specification
🤖 Generated with Claude via commitment
docs(spec): add hook bug fix requirement to logger spec
{2}parameter check in prepare-commit-msg🤖 Generated with Claude via commitment
docs(spec): add implementation plan for logger interface
🤖 Generated with Claude via commitment