Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix navigationbar size #46

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Bugfix navigationbar size #46

wants to merge 9 commits into from

Conversation

zhiweideng
Copy link

What’s the problem?

  • FlashBar running in Android SDK 29, The problem is that the height of the NavigationBar is calculated incorrectly.
    Screenshot_1621500438

  • FlashBar running in Android SDK 23, Setting the bottomMargin of FlashbarContainerView does not take effect.
    Screenshot_1621500444

Solution

  • When FlashBar gravity == bottom, add FlashbarContainerView to the contentView of Activity, so that we don’t need to set the bottomMargin value of FlashbarContainerView, avoid calculating the wrong navigationBar height value and setting the bottomMargin of FlashbarContainerView unsuccessfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhiweideng