Skip to content

Comments

Python Update and Defunct Model Cleaning#19

Merged
aritraghsh09 merged 8 commits intomasterfrom
py310
Jul 9, 2025
Merged

Python Update and Defunct Model Cleaning#19
aritraghsh09 merged 8 commits intomasterfrom
py310

Conversation

@aritraghsh09
Copy link
Owner

No description provided.

@aritraghsh09 aritraghsh09 self-assigned this Jul 8, 2025
@aritraghsh09 aritraghsh09 linked an issue Jul 8, 2025 that may be closed by this pull request
@aritraghsh09 aritraghsh09 changed the title Py310 Python Update and Defunct Model Cleaning Jul 8, 2025
@aritraghsh09 aritraghsh09 marked this pull request as ready for review July 9, 2025 17:50
@aritraghsh09 aritraghsh09 requested a review from Copilot July 9, 2025 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to support Python 3.10+ and removes deprecated GGT models (ggt and ggt_no_gconv) that are no longer maintained. The changes include cleaning up model references, updating documentation to reflect the changes, and modernizing PyTorch API usage.

Key changes:

  • Removal of defunct GGT models and their associated test cases
  • Update of PyTorch VGG16 model instantiation to use the new weights parameter syntax
  • Documentation updates to reflect Python 3.10+ requirement and deprecated models

Reviewed Changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ggt/tests/test_models.py Removes test cases for deprecated GGT models
ggt/models/init.py Removes GGT model imports and factory method references
ggt/models/vgg.py Updates VGG16 model instantiation to use modern PyTorch weights syntax
docs/source/Using_GaMPEN.md Documents removal of GGT models with strikethrough formatting
docs/source/Getting_Started.md Updates Python version requirement from 3.7/3.8 to 3.10+
.github/workflows/main.yml Updates CI pipeline to use Python 3.10
ggt/modules/autocrop.py Minor formatting improvements and comment correction
ggt/modules/result_aggregator.py Removes extra blank lines for consistency
docs/source/conf.py Code formatting improvements and adds strikethrough extension
Makefile Updates download URLs for demo data

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aritraghsh09 aritraghsh09 merged commit a517e56 into master Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make requirements.txt more lightweight

1 participant