Python Update and Defunct Model Cleaning#19
Merged
aritraghsh09 merged 8 commits intomasterfrom Jul 9, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to support Python 3.10+ and removes deprecated GGT models (ggt and ggt_no_gconv) that are no longer maintained. The changes include cleaning up model references, updating documentation to reflect the changes, and modernizing PyTorch API usage.
Key changes:
- Removal of defunct GGT models and their associated test cases
- Update of PyTorch VGG16 model instantiation to use the new weights parameter syntax
- Documentation updates to reflect Python 3.10+ requirement and deprecated models
Reviewed Changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ggt/tests/test_models.py | Removes test cases for deprecated GGT models |
| ggt/models/init.py | Removes GGT model imports and factory method references |
| ggt/models/vgg.py | Updates VGG16 model instantiation to use modern PyTorch weights syntax |
| docs/source/Using_GaMPEN.md | Documents removal of GGT models with strikethrough formatting |
| docs/source/Getting_Started.md | Updates Python version requirement from 3.7/3.8 to 3.10+ |
| .github/workflows/main.yml | Updates CI pipeline to use Python 3.10 |
| ggt/modules/autocrop.py | Minor formatting improvements and comment correction |
| ggt/modules/result_aggregator.py | Removes extra blank lines for consistency |
| docs/source/conf.py | Code formatting improvements and adds strikethrough extension |
| Makefile | Updates download URLs for demo data |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.