Subject: Pull Request: Adding withNotNull Function in Notes App#94
Merged
aritra-tech merged 2 commits intoaritra-tech:developfrom Sep 30, 2023
Merged
Subject: Pull Request: Adding withNotNull Function in Notes App#94aritra-tech merged 2 commits intoaritra-tech:developfrom
aritra-tech merged 2 commits intoaritra-tech:developfrom
Conversation
Owner
|
Hey @yogesh-7 can you create an issue first and please raise a PR against |
aritra-tech
approved these changes
Sep 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the withNotNull function, an extension function that simplifies working with nullable values, into the existing codebase. The withNotNull function allows you to apply a specified lambda expression to a non-null value and return the result, or return null if the receiver value is null. This addition enhances the code's readability and safety by reducing the need for explicit null checks in various parts of the application.
Merge Request Details:
Branch: (yogesh-7:Notify:share_utils_fix)
Target Branch: (aritra-tech:Notify:master)
Changes Made
Added the withNotNull function to the project's utility library (package: com.aritra.notify.utils).
Documented the function with appropriate comments, including its purpose, parameters, return value, and usage examples.
Testing
Comprehensive unit tests have been added to validate the functionality of the withNotNull function, covering scenarios with both non-null and null receiver values.
Existing test cases have been reviewed and updated where necessary to leverage the new withNotNull function.
Documentation
Updated the project's documentation to include information about the withNotNull function, its purpose, and how to use it.
Checklist
Code compiles without errors or warnings.
New unit tests have been added, and existing tests have been reviewed and updated.
The documentation has been updated.
Code follows the project's coding standards and style guide.
Additional Notes
This feature adds a valuable utility function to simplify and enhance code safety.
Please review the code and provide feedback, so we can proceed with merging this feature into the codebase.
This pull request description includes details about the purpose of the change, the changes made, usage examples, testing, documentation updates, and a checklist for reviewers to follow. Adjust it as needed to match your specific project and review process.