Skip to content

feature: Add sorting options for notes.#129

Merged
aritra-tech merged 2 commits intoaritra-tech:developfrom
V9vek:feature/SortingOptionsForNotes
Oct 10, 2023
Merged

feature: Add sorting options for notes.#129
aritra-tech merged 2 commits intoaritra-tech:developfrom
V9vek:feature/SortingOptionsForNotes

Conversation

@V9vek
Copy link
Contributor

@V9vek V9vek commented Oct 8, 2023

Added the notes sorting feature, resolving the issue #118

It includes sorting notes based on:

Date (Oldest | Newest)
Title (A-Z | Z-A)
You can see the implementation in the attached video.
And one more thing, the Gradle Lint is showing error out of nowhere every time

If this looks good to you, please merge the request 😊
or if you need some changes, please do ping me.

noteapp.mp4

@aritra-tech
Copy link
Owner

Hey @V9vek can you please fix the ktlint check.
Just run ./gradlew ktlintCheck --continue in your terminal and check which lines are showing the error.

@V9vek
Copy link
Contributor Author

V9vek commented Oct 10, 2023

Hey @V9vek can you please fix the ktlint check. Just run ./gradlew ktlintCheck --continue in your terminal and check which lines are showing the error.

okay sure

@V9vek
Copy link
Contributor Author

V9vek commented Oct 10, 2023

@aritra-tech can you check now?

Copy link
Owner

@aritra-tech aritra-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌
Nice work @V9vek

@aritra-tech aritra-tech merged commit 8389997 into aritra-tech:develop Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants