Skip to content

Add feat: User can pick multiple image + zoom and pan across image#115

Merged
aritra-tech merged 5 commits intoaritra-tech:developfrom
beradeep:develop
Oct 6, 2023
Merged

Add feat: User can pick multiple image + zoom and pan across image#115
aritra-tech merged 5 commits intoaritra-tech:developfrom
beradeep:develop

Conversation

@beradeep
Copy link
Contributor

@beradeep beradeep commented Oct 4, 2023

Implementations

  1. User can pick multiple images
  2. User can zoom and pan across image

Solves #72

@aritra-tech
Copy link
Owner

aritra-tech commented Oct 4, 2023

Can you provide a video with the working features that you have done in this PR @beradeep?
And always remember whenever you create a branch try to name that branch relevant to the issue which you are solving.

@aritra-tech
Copy link
Owner

Please solve the merge conflict also @beradeep

@beradeep
Copy link
Contributor Author

beradeep commented Oct 4, 2023

Hey @aritra-tech I have solved the merge conflicts, but these ktlintChecks are messing it up, otherwise the build is working.

@aritra-tech
Copy link
Owner

Hey @aritra-tech I have solved the merge conflicts, but these ktlintChecks are messing it up, otherwise the build is working.

Yeah leave it, I will fix this up after merging it to develop.
Just send me the video of this feature that you have worked on.

@beradeep
Copy link
Contributor Author

beradeep commented Oct 5, 2023

Yeah, I'll send the video today.

@beradeep
Copy link
Contributor Author

beradeep commented Oct 5, 2023

PR.video.recording.1.mp4

Hey @aritra-tech, here's the video showing the features that I worked upon and implemented:

  1. Multiple image selection.
  2. Zooming and panning through an image.

@aritra-tech
Copy link
Owner

Also, check how the images are showing when the layout is changed to grid view.

@aritra-tech
Copy link
Owner

Nice work @beradeep 🙌
Will be merging soon.
Thank you 🌟

@beradeep
Copy link
Contributor Author

beradeep commented Oct 6, 2023

Nice work @beradeep 🙌 Will be merging soon. Thank you 🌟

Thanks @aritra-tech, happy to see it getting merged 😃 !

Copy link
Owner

@aritra-tech aritra-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌🚀

@aritra-tech aritra-tech merged commit 25ea790 into aritra-tech:develop Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants