fix: Support other encoding than UTF-8 #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue with email being sent with other encoding than UTF-8 and then being not properly handled in the javascript code.
By default, toString on S3 file expects UTF-8, so from that moment if it is in other encoding, email will be received broken.
This reads the email using the toString method and tries to find
text/plain; charset=(encoding)to decide which encoding provide to TextDecoder function.Then also the header needs to be modified as we from this moment are working with UTF-8.
Tested with Windows-1250 and ISO-8859-2 where text is now fixed if the email is sent with this encoding.