sync #1
Merged
sync #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to add async attribute to stop Google Page Speed Insights complaining from render-blocking CSS being loaded.
Unfortunately, the native font load API in Safari 10 has two bugs that cause the document.fonts.load and FontFace.prototype.load methods to return promises that don't reliably get settled (i.e. either rejected or resolved). The bugs are described in more detail here: https://bugs.webkit.org/show_bug.cgi?id=165037 https://bugs.webkit.org/show_bug.cgi?id=164902 Until patches for these bugs have landed in a stable version this pull request will disable using the native font loading API on Safari 10. The code only targets Safari 10 (all versions) because the patches will most likely land before a new major version is released.
…afari10 Disable native font loading in Safari 10
Always use https for fonts.googleapis.com
Async attribute when using asynchronously
…ner after the loader promise has already resolved; to prevent Chrome DevTools from pausing. Fixes #362
Prevent Chrome DevTools pausing on Promise rejection when fonts load successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.