Feat(eos_designs): Add support of management console and banners#6728
Feat(eos_designs): Add support of management console and banners#6728vitthalmagadum wants to merge 13 commits intoaristanetworks:develfrom
Conversation
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6728
# Activate the virtual environment
source test-avd-pr-6728/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/vitthalmagadum/avd.git@feat/management_settings#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
python -m ansible.cli.galaxy collection install git+https://github.com/vitthalmagadum/avd.git#/ansible_collections/arista/avd/,feat/management_settings --force
cd test-avd-pr-6728
# Run your playbook using `python -m ansible.cli.playbook path/to/playbook.yml ...`You can also test this PR using AVD playground:
|
ansible_collections/arista/avd/roles/eos_designs/docs/data-models.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
|
plesaae @vitthalmagadum make sure to cover every branch here (it is just adding a test where you don't set the inputs) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #6728 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 351 351
Lines 19358 19366 +8
Branches 3619 3622 +3
=======================================
+ Hits 16912 16920 +8
Misses 1884 1884
Partials 562 562
🚀 New features to boost your workflow:
|
Updated the tests. Thanks!! |
MaheshGSLAB
left a comment
There was a problem hiding this comment.
LGTM me apart for one comment to discuss more
ansible_collections/arista/avd/roles/eos_designs/docs/data-models.md
Outdated
Show resolved
Hide resolved
ClausHolbechArista
left a comment
There was a problem hiding this comment.
blocking this to revisist main key. I am not sure management_settings makes sense here
no longer blocking. We had settled on the schema already.
...ons/molecule/eos_designs_unit_tests/inventory/host_vars/management-settings-login-banner.yml
Show resolved
Hide resolved
...ions/molecule/eos_designs_unit_tests/inventory/host_vars/management-settings-motd-banner.yml
Show resolved
Hide resolved
...tensions/molecule/eos_designs_unit_tests/inventory/host_vars/management-settings-console.yml
Outdated
Show resolved
Hide resolved
...ensions/molecule/eos_designs_unit_tests/inventory/host_vars/management-settings-login-banner
Outdated
Show resolved
Hide resolved
...tensions/molecule/eos_designs_unit_tests/inventory/host_vars/management-settings-motd-banner
Outdated
Show resolved
Hide resolved
| management_settings: | ||
| type: dict | ||
| documentation_options: | ||
| table: management_settings |
There was a problem hiding this comment.
We use hyphens:
| table: management_settings | |
| table: management-settings |
There was a problem hiding this comment.
updated. thanks!
| $ref: eos_cli_config_gen#/keys/management_console | ||
| banners: | ||
| type: dict | ||
| $ref: eos_cli_config_gen#/keys/banners |
There was a problem hiding this comment.
The docs table says: "Multiline string ending with EOF on the last line." But looking at banner.j2 template, we auto-append \nEOF\n if the string does not already end with it. Users do not need to add it themselves. We should update the description in eos_cli_config_gen.
There was a problem hiding this comment.
updated description, removed EOF from description. Thanks!!
| # Test for management settings | ||
| type: l2leaf | ||
| l2leaf: | ||
| defaults: |
There was a problem hiding this comment.
Same with other host_vars files.
| defaults: |
There was a problem hiding this comment.
updated. thanks!!
|



Change Summary
Add support of management console and banners (part of #6265 )
Related Issue(s)
Fixes #6727
Component(s) name
arista.avd.eos_designProposed changes
Add support of management console and banners
How to test
Run Molecule
Checklist
User Checklist
Repository Checklist