Skip to content

Feat(eos_designs): Add support of management console and banners#6728

Open
vitthalmagadum wants to merge 13 commits intoaristanetworks:develfrom
vitthalmagadum:feat/management_settings
Open

Feat(eos_designs): Add support of management console and banners#6728
vitthalmagadum wants to merge 13 commits intoaristanetworks:develfrom
vitthalmagadum:feat/management_settings

Conversation

@vitthalmagadum
Copy link
Copy Markdown
Contributor

Change Summary

Add support of management console and banners (part of #6265 )

Related Issue(s)

Fixes #6727

Component(s) name

arista.avd.eos_design

Proposed changes

Add support of management console and banners

How to test

Run Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@vitthalmagadum vitthalmagadum requested review from a team as code owners March 20, 2026 11:45
@vitthalmagadum vitthalmagadum marked this pull request as draft March 20, 2026 11:45
@github-actions
Copy link
Copy Markdown

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6728
# Activate the virtual environment
source test-avd-pr-6728/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/vitthalmagadum/avd.git@feat/management_settings#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
python -m ansible.cli.galaxy collection install git+https://github.com/vitthalmagadum/avd.git#/ansible_collections/arista/avd/,feat/management_settings --force
cd test-avd-pr-6728
# Run your playbook using `python -m ansible.cli.playbook path/to/playbook.yml ...`

You can also test this PR using AVD playground:

  • Rebase your branch to makes sure it is up-to-date and has latest lab topologies for example inventories
  • Authenticate on labs.arista.com. Use your email! Not login.
  • Start the playground
  • In the lab selector UI pick "I want to use a specific AVD fork"
  • Enter following parameters:
GitHub org: vitthalmagadum
Repository name: avd
Branch: feat/management_settings
  • Select an example inventory to test the PR
  • Once the AVD Playground setup will be finished, type make start and test anything once the lab is up

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Mar 20, 2026
@gmuloc
Copy link
Copy Markdown
Contributor

gmuloc commented Mar 23, 2026

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.36%. Comparing base (d668056) to head (2910b32).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            devel    #6728   +/-   ##
=======================================
  Coverage   87.36%   87.36%           
=======================================
  Files         351      351           
  Lines       19358    19366    +8     
  Branches     3619     3622    +3     
=======================================
+ Hits        16912    16920    +8     
  Misses       1884     1884           
  Partials      562      562           
Files with missing lines Coverage Δ
...vd/_eos_designs/structured_config/base/__init__.py 97.19% <100.00%> (+0.04%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vitthalmagadum
Copy link
Copy Markdown
Contributor Author

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review March 24, 2026 06:07
Copy link
Copy Markdown
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM me apart for one comment to discuss more

Copy link
Copy Markdown
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this to revisist main key. I am not sure management_settings makes sense here

@ClausHolbechArista ClausHolbechArista dismissed their stale review March 26, 2026 20:00

no longer blocking. We had settled on the schema already.

management_settings:
type: dict
documentation_options:
table: management_settings
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use hyphens:

Suggested change
table: management_settings
table: management-settings

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. thanks!

$ref: eos_cli_config_gen#/keys/management_console
banners:
type: dict
$ref: eos_cli_config_gen#/keys/banners
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs table says: "Multiline string ending with EOF on the last line." But looking at banner.j2 template, we auto-append \nEOF\n if the string does not already end with it. Users do not need to add it themselves. We should update the description in eos_cli_config_gen.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated description, removed EOF from description. Thanks!!

# Test for management settings
type: l2leaf
l2leaf:
defaults:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with other host_vars files.

Suggested change
defaults:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. thanks!!

@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Apr 3, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Add support of management console and banners

6 participants