Skip to content

Handle dot and hyphen in mlag domain-id string #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
grybak-arista merged 3 commits into from
Mar 28, 2016
Merged

Handle dot and hyphen in mlag domain-id string #92

grybak-arista merged 3 commits into from
Mar 28, 2016

Conversation

@grybak-arista
Copy link
Contributor

@grybak-arista grybak-arista commented Mar 24, 2016

fixes #91
Addresses arista-eosplus/ansible-eos#90

Release Note:
Include handling any character in domain-id string, including dot, hyphen, and space

@grybak-arista
fixes #91
0288770 
include dot and hyphen in regex match for domain-id
@coveralls
Copy link

coveralls commented Mar 24, 2016

Coverage Status

Coverage remained the same at 96.063% when pulling 0288770 on mlag_fix into 69959ad on develop.

@coveralls
Copy link

coveralls commented Mar 28, 2016

Coverage Status

Coverage remained the same at 96.063% when pulling 10e5c5f on mlag_fix into 69959ad on develop.

@coveralls
Copy link

coveralls commented Mar 28, 2016

Coverage Status

Coverage remained the same at 96.063% when pulling 634131e on mlag_fix into 69959ad on develop.

@grybak-arista grybak-arista merged commit edb076a into develop Mar 28, 2016
@grybak-arista grybak-arista deleted the mlag_fix branch March 28, 2016 17:56
@phil-dileo phil-dileo added the bug label Sep 7, 2016
@phil-dileo phil-dileo added this to the 0.7.0 milestone Sep 7, 2016
@phil-dileo phil-dileo removed the bug label Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

Allow dot and hyphen in mlag domain-id

4 participants

@grybak-arista @coveralls @phil-dileo