Skip to content

fixing system test issue where mlag test fails on Ethernet1 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlyssenko merged 1 commit into from
Aug 15, 2024
Merged

fixing system test issue where mlag test fails on Ethernet1 #303

dlyssenko merged 1 commit into from
Aug 15, 2024

Conversation

@dlyssenko
Copy link
Contributor

@dlyssenko dlyssenko commented Aug 14, 2024

  1. test_api_mlag runs after test_api_interfaces. The latter selects a guinea-pig interface via random_interface() call
  2. test_api_mlag always selects interface Ethernet1 for its test.
  3. Thus, if test_api_interfaces picks Ethernet1 by chance, it leaves it with flow-control configured, which breaks then mlag test

This trivial fix excludes Ethernet1 from being selected in test_api_interfaces

mharista
mharista approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@mharista mharista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dlyssenko dlyssenko merged commit 519be98 into arista-eosplus:develop Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mharista mharista mharista approved these changes

@stefanos-sagkriotis-arista stefanos-sagkriotis-arista Awaiting requested review from stefanos-sagkriotis-arista

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlyssenko @mharista