Skip to content

Include error message in CommandError for internal exceptions #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlyssenko merged 1 commit into from
Apr 28, 2023
Merged

Include error message in CommandError for internal exceptions #252

dlyssenko merged 1 commit into from
Apr 28, 2023

Conversation

@dkaplan1
Copy link

@dkaplan1 dkaplan1 commented Mar 15, 2023 •
edited
Loading

Internal exceptions (error code 1001) currently do not have the actual error message included within CommandError, which hinders debugging.

Before

pyeapi.eapilib.CommandError: Error [1001]: CLI command 10 of 11 '   no shutdown' failed: internal error

After

pyeapi.eapilib.CommandError: Error [1001]: CLI command 10 of 11 '   no shutdown' failed: internal error [[Errno 13] Permission denied: '/usr/local/bin/foo']

@ryanmerolle
Copy link
Contributor

ryanmerolle commented Apr 28, 2023

LGTM

@dlyssenko dlyssenko merged commit 285116c into arista-eosplus:develop Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkaplan1 @ryanmerolle @dlyssenko