config modules don't raise error if the credentials are incorrect

[noredistribution]

For example when trying to create vlans if the credentials are incorrect we only print False

e.g. if you do something like this

import pyeapi

connect = pyeapi.connect_to("leaf1-DC1")
print(connect)

vlan_ids = ["10","20","30","40","50"]

for vlan in vlan_ids:
    connect.api('vlans').create(vlan)
    print(f"Creating vlan {vlan}")

that doesn't raise any error; if you print the connect statement then it prints False, wherease if you use get or getallfunctions that raises the correct error

  File "/usr/local/lib/python3.7/dist-packages/pyeapi/eapilib.py", line 455, in send
    response_content))
pyeapi.eapilib.ConnectionError: Unauthorized. b'Unable to authenticate user: Bad username/password combination'

seems like we don't raise error here:

pyeapi/pyeapi/api/abstract.py

Line 126 in 9d90ad8

except (CommandError, ConnectionError):

[ldn-softdev]

let me check the idea behind handling exception due to ConnectionError inband and I'll get back to this one.

[ldn-softdev]

Okay, the challenge to accommodate this ask was to understand why ConnectionError exception was added to the intercept in first place in this diff.
I've asked around and it seems a collective opinion is that it makes more sense to handle such failures indeed via exception, rather than via inband handling. Removing ConnectionError might break some customers' scripts which already provided some error handling for connection reasons. But in worse case scenario (if there are big complains) we always can put it back (but hopefully not, 'cause ideologically, it's better be that way).
So, I'll proceed fixing it.