feat: write flight log to csv #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mara171
reviewed
Nov 8, 2025
mara171
left a comment
mara171
left a comment
There was a problem hiding this comment.
lots of clippy errors, but seems sensible
Indeximal
reviewed
Nov 8, 2025
Collaborator
Indeximal
left a comment
Indeximal
left a comment
There was a problem hiding this comment.
Cool, you made it work! I am confident with more time you could have made it work with clippy and fmt with some more time.
| use serde::Serialize; | ||
|
|
||
| /// Stores the current inputs of the system, given by the avionics | ||
| #[derive(serde::Serialize)] |
Collaborator
There was a problem hiding this comment.
this isn't needed anymore
| let mut ser = AsyncSerializer::from_writer(vec![]); | ||
|
|
||
| let mut wrt = AsyncWriterBuilder::new().has_headers(true).create_writer(vec![]); | ||
| let mut ser_2 = AsyncSerializer::from_writer(vec![]); |
Collaborator
There was a problem hiding this comment.
I mean, you know yourself that this isn't the best variable name, but idk
Collaborator
There was a problem hiding this comment.
you could have excluded this in gitignores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement async datalog