fix: hide sensitive input

Fixes #28 by using Go's x/term package's ReadPassword
aripalo · May 12, 2022 · af886e5 · af886e5
1 parent 9ee92c0
commit af886e5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/internal/msg/msg.go b/internal/msg/msg.go
@@ -67,7 +67,7 @@ func Error(prefix emoji.Emoji, message string) {
 }
 
 func Prompt(prefix emoji.Emoji, message string) {
-	d.Promptln(prefix, message)
+	d.Prompt(prefix, message)
 }
 
 func Fatal(message string) {

diff --git a/internal/prompt/prompt.go b/internal/prompt/prompt.go
@@ -1,12 +1,12 @@
 package prompt
 
 import (
-	"bufio"
 	"context"
-	"os"
 	"strings"
+	"syscall"
 
 	"github.com/ncruces/zenity"
+	"golang.org/x/term"
 )
 
 func Password(ctx context.Context, title string, text string) (string, error) {
@@ -37,12 +37,11 @@ func Dialog(ctx context.Context, title string, text string) (string, error) {
 }
 
 func Cli(ctx context.Context, text string) (string, error) {
-	reader := bufio.NewReader(os.Stdin)
 
-	value, err := reader.ReadString('\n')
+	value, err := term.ReadPassword(int(syscall.Stdin))
 	if err != nil {
 		return "", err
 	}
 
-	return strings.TrimSpace(value), nil
+	return strings.TrimSpace(string(value)), nil
 }