Skip to content

Conversation

@arika0093
Copy link
Owner

@arika0093 arika0093 commented Nov 16, 2025

Summary by CodeRabbit

  • Chores
    • Added automated verification workflow for NuGet package builds, including validation of packaged output and sample program execution.

@coderabbitai
Copy link

coderabbitai bot commented Nov 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A new GitHub Actions workflow file is introduced to verify NuGet package integrity. The workflow automates building, packing the project, establishing a local NuGet source, creating a test project that consumes the packaged Linqraft library, and validating the output against expected results.

Changes

Cohort / File(s) Summary
NuGet Verification Workflow
\.github/workflows/verify-package\.yaml
New workflow file that orchestrates package verification: checks out code, sets up .NET environment, restores dependencies, packs the project, configures local NuGet source, creates verification test project with sample Program.cs, and validates output contains expected result ("John Doe").

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions
    participant Build as Build & Pack
    participant NuGet as NuGet Setup
    participant Test as Test Project
    participant Verify as Verification

    GHA->>Build: Checkout & Restore
    GHA->>Build: Build & Pack project
    Build-->>GHA: Create .nupkg

    GHA->>NuGet: Setup local NuGet source
    NuGet-->>GHA: Source ready

    GHA->>Test: Create verification project
    GHA->>Test: Reference packaged Linqraft
    Test->>Test: Copy sample Program.cs

    GHA->>Test: Build verification project
    Test-->>GHA: Build complete

    GHA->>Verify: Run program
    Verify-->>GHA: Output received

    GHA->>Verify: Assert "John Doe" in output
    Verify-->>GHA: ✓ Verification passed
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify workflow syntax and GitHub Actions configuration accuracy
  • Check NuGet packaging and sourcing steps for correctness
  • Validate output assertion logic and test project setup

Poem

🐰 A workflow springs to life so neat,
To verify each package we'll meet,
Build and pack with careful stride,
Test the code with rabbit pride,
John Doe appears—hooray, it's right!

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-verify-package-wf

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 409f41d and d0494ad.

📒 Files selected for processing (1)
  • .github/workflows/verify-package.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arika0093 arika0093 merged commit 6d33e3c into main Nov 16, 2025
3 of 4 checks passed
@arika0093 arika0093 deleted the feat/add-verify-package-wf branch November 16, 2025 05:38
arika0093 added a commit that referenced this pull request Nov 17, 2025
feat: add workflow to verify NuGet package installation and functionality (#29)

docs: update C# version requirements and remove Polysharp references in README files

docs: update C# version requirements and add details on language features in README files

Enhance method header generation to include location type (#30)

* feat: enhance method header generation to include location type in SelectExpr records

* feat: add expression type string for documentation in SelectExpr records

chore: remove branch restrictions from NuGet package verification workflow

fix: update descendant node retrieval to include the current node in HasNullableAccess method

fix: enable locked mode for dotnet restore in workflow files

refactor: streamline NuGet package verification workflow by consolidating directory creation and file copying steps

refactor: remove unnecessary TargetFrameworks from project files

refactor: remove Windows from build matrix due to performance issues

chore: Separate core functionalities into Linqraft.Core project (#31)

* chore: Separate core functionalities from SourceGenerator project into Linqraft.Core project

* feat: add GetExprTypeString method for documentation of anonymous expression types

* chore: disable documentation file generation in Directory.Build.props

fix: add missing comma and restore additionalVersions in devcontainer.json

fix: add missing PropertyGroup for DevelopmentDependency in Linqraft.csproj

close #35

fix: remove PolySharp package reference from Directory.Build.props

Revert "fix: add missing PropertyGroup for DevelopmentDependency in Linqraft.csproj"

This reverts commit 7916999.

Revert "fix: add missing comma and restore additionalVersions in devcontainer.json"

This reverts commit 8a386ab.

Reapply "fix: add missing comma and restore additionalVersions in devcontainer.json"

This reverts commit 1743adc.

Reapply "fix: add missing PropertyGroup for DevelopmentDependency in Linqraft.csproj"

This reverts commit ad3f14a.

Revert "fix: remove PolySharp package reference from Directory.Build.props"

This reverts commit 5b1a189.

fix: add PolySharp package reference and update LangVersion instructions in README files

fix: update generic type parameters in SelectExpr methods for consistency

fix: update build instructions to ensure a clean build without incremental compilation

fix: add clean-test.sh script for easier test cleanup and build process

fix: update SelectExpr method signatures for consistency across implementations

close #33

fix: change Issue33_SealedPatternTest class to partial for extensibility

fix: refactor DummyExpression class and update SelectExpr method summaries for clarity (#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants