feat: Add EmbeddedAttribute for source generation in ExportAllConstantSnippets #242

arika0093 · 2025-12-10T15:33:17Z

Introduce the EmbeddedAttribute to facilitate source generation in the ExportAllConstantSnippets method, enhancing the attribute system for generated code.

close #227

Summary by CodeRabbit

Chores
- Removed obsolete platform-specific entries from dependency configurations across projects.
Refactor
- Enhanced code generation infrastructure with improved attribute handling for generated source files.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…tSnippets

coderabbitai · 2025-12-10T15:33:29Z

Walkthrough

This pull request introduces an EmbeddedAttribute marker annotation to internal source-generated attributes (InterceptsLocationAttribute and LinqraftAutoGeneratedDtoAttribute) to prevent them from leaking through [InternalVisibleTo] declarations. Additionally, empty Windows-specific target entries are removed from three NuGet lock files as structural cleanup.

Changes

Cohort / File(s)	Summary
Lock file cleanup `src/Linqraft.Analyzer/packages.lock.json`, `src/Linqraft.Core/packages.lock.json`, `src/Linqraft.SourceGenerator/packages.lock.json`	Removed empty platform-specific target entries (`.NETStandard,Version=v2.0/win-x64`) from dependency graphs
EmbeddedAttribute source generation `src/Linqraft.Core/GenerateSourceCodeSnippets.cs`	Added new public constant `EmbeddedAttribute` containing C# source code; emitted as generated source `EmbeddedAttribute.g.cs`; applied `[EmbeddedAttribute]` annotation to `InterceptsLocationAttribute` and `LinqraftAutoGeneratedDtoAttribute`; added `using Microsoft.CodeAnalysis;` imports

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Lock file changes are straightforward structural cleanup with no behavioral impact
Primary review focus: src/Linqraft.Core/GenerateSourceCodeSnippets.cs — verify that the EmbeddedAttribute constant correctly generates valid C# source code and that the attribute annotations are applied to the correct generated types

Possibly related PRs

Implement centralized source code generation and clean up project references #25 — Centralizes generated source definitions including InterceptsLocationAttribute, which this PR directly enhances by adding the [EmbeddedAttribute] annotation.

Poem

🐰 A marker so tiny, yet mighty and keen,
Prevents attribute leaks in the in-between,
With [Embedded] declared, our attributes stay tight,
No sneaking through backdoors—what a delight! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adding EmbeddedAttribute for source generation in ExportAllConstantSnippets, which is the primary objective of the pull request.
Linked Issues check	✅ Passed	The code changes successfully implement the objective from issue #227 by adding EmbeddedAttribute with proper annotations to InterceptsLocationAttribute and LinqraftAutoGeneratedDtoAttribute to prevent attribute leakage.
Out of Scope Changes check	✅ Passed	All changes are directly related to the linked issue #227 objectives; the packages.lock.json updates are supporting maintenance changes with no unrelated modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/add-embbed-attribute

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca5f105 and 0ea9d42.

📒 Files selected for processing (4)

src/Linqraft.Analyzer/packages.lock.json (1 hunks)
src/Linqraft.Core/GenerateSourceCodeSnippets.cs (3 hunks)
src/Linqraft.Core/packages.lock.json (1 hunks)
src/Linqraft.SourceGenerator/packages.lock.json (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/Linqraft.{Analyzer,Core}/**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

src/Linqraft.{Analyzer,Core}/**/*.cs: Always prefer semantic analysis over string matching; use RoslynTypeHelper instead of string-based type checking
Use ISymbolEqualityComparer for symbol comparisons in analyzer code

Files:

src/Linqraft.Core/GenerateSourceCodeSnippets.cs

src/Linqraft.Core/**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

src/Linqraft.Core/**/*.cs: Keep helper methods lightweight and focused; helper methods are called frequently during analysis
Cache expensive operations in helper methods when possible

Files:

src/Linqraft.Core/GenerateSourceCodeSnippets.cs

🧠 Learnings (14)

📚 Learning: 2025-12-05T13:51:45.005Z

Learnt from: arika0093
Repo: arika0093/Linqraft PR: 210
File: .github/workflows/test-strict.yaml:17-17
Timestamp: 2025-12-05T13:51:45.005Z
Learning: In the Linqraft repository, the library projects (src/) target netstandard2.0, which maintains compatibility with .NET 6.0 and older versions. The test matrix in .github/workflows/test-strict.yaml specifies which .NET versions are used to run tests, not the library's compatibility. Changes to the test matrix (TFMS variable) do not affect library compatibility and should not be treated as breaking changes.

Applied to files:

src/Linqraft.SourceGenerator/packages.lock.json
src/Linqraft.Core/packages.lock.json
src/Linqraft.Analyzer/packages.lock.json