refactor: DTO handling and improve code clarity #216

arika0093 · 2025-12-06T12:59:08Z

Enhance the code structure by replacing hardcoded DTO attributes with a dedicated method, improving maintainability. Rename the ExportAll method for clarity and add documentation for auto-generated DTO attributes. Introduce the EditorBrowsable attribute to control visibility of internal DTO attributes.

Summary by CodeRabbit

Refactor
- Reorganized internal code generation processes to improve maintainability. Enhanced DTO attribute handling through centralized code snippet management and better code organization.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…ated DTO attribute

…arity

…r better maintainability

…r better visibility control

coderabbitai · 2025-12-06T12:59:17Z

Walkthrough

The pull request refactors DTO attribute generation by centralizing it into a dedicated method, renames a public API method in the source code generator infrastructure, and updates the post-initialization registration to use the renamed method. These changes maintain existing functionality while improving code organization.

Changes

Cohort / File(s)	Summary
Source Code Snippets Refactoring `src/Linqraft.Core/GenerateSourceCodeSnippets.cs`	Renamed public method `ExportAll()` to `ExportAllConstantSnippets()`, added new public method `BuildDtoCodeAttributes()` that returns DTO attribute source code, and introduced new public constant `LinqraftAutoGeneratedDtoAttribute` for centralized attribute metadata.
Post-Initialization Registration Update `src/Linqraft.SourceGenerator/SelectExprGenerator.cs`	Updated post-initialization source generation call to use the renamed `ExportAllConstantSnippets` method directly, removing the previous lambda wrapper pattern.
DTO Attribute Generation `src/Linqraft.Core/GenerateDtoClassInfo.cs`	Replaced explicit attribute line insertions with centralized generation via `GenerateSourceCodeSnippets.BuildDtoCodeAttributes()`, applying indentation through `CodeFormatter.IndentCodeByLevel()`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Straightforward refactoring with consistent pattern changes across files
Method rename and extraction are mechanical transformations
Verify that BuildDtoCodeAttributes() output matches the previously explicit attribute lines

Possibly related PRs

chore: Separate core functionalities into Linqraft.Core project #31 — Directly modifies the same three files with related changes to method names and attribute generation centralization
Implement centralized source code generation and clean up project references #25 — Related refactoring that also centralizes generator-provided source snippets and updates post-initialization registration patterns

Poem

🐰 Code once scattered, now it's neat,
Attributes gathered, centralized sweet,
One method renamed, the flow stays true,
Refactoring whispers, making things new! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor: DTO handling and improve code clarity' directly relates to the main changes: centralizing DTO attribute generation and renaming ExportAll for clarity.
Docstring Coverage	✅ Passed	Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/source-snippet-update

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51cc4eb and 19d8834.

📒 Files selected for processing (3)

src/Linqraft.Core/GenerateDtoClassInfo.cs (1 hunks)
src/Linqraft.Core/GenerateSourceCodeSnippets.cs (6 hunks)
src/Linqraft.SourceGenerator/SelectExprGenerator.cs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/Linqraft.{Analyzer,Core}/**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

src/Linqraft.{Analyzer,Core}/**/*.cs: Always prefer semantic analysis over string matching; use RoslynTypeHelper instead of string-based type checking
Use ISymbolEqualityComparer for symbol comparisons in analyzer code

Files:

src/Linqraft.Core/GenerateDtoClassInfo.cs
src/Linqraft.Core/GenerateSourceCodeSnippets.cs

src/Linqraft.Core/**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

src/Linqraft.Core/**/*.cs: Keep helper methods lightweight and focused; helper methods are called frequently during analysis
Cache expensive operations in helper methods when possible

Files:

src/Linqraft.Core/GenerateDtoClassInfo.cs
src/Linqraft.Core/GenerateSourceCodeSnippets.cs

🧠 Learnings (12)