Repository navigation
feat(ade, onboarding): redesign the setup dialog and the guided tour - #1
Closed
arihantcodes wants to merge 2 commits into
Closed
arihantcodes wants to merge 2 commits into
arihantcodes wants to merge 2 commits into
Conversation
Setup dialog (ade/web/src/components/onboarding): - 760×620 frame with a 200px rail: a vertical stepper of numbered dots on a hairline that fills as steps complete, with a one-line description per step; a one-row stepper below the @lg container width. Finished steps go back on click; the current one carries aria-current; steps ahead are text. - One spacing system (24px gutter, 56px footer, a close-button strip the body never scrolls under), 12px-cornered pill buttons with semibold labels, pill chips, bordered cards with hairline dividers, and surface-token hovers and selection so every state is the same step in both themes. - Models: sign-in commands in a dark terminal block with bash colouring and a copy button; the engine log on the same surface, no longer a nested scroller. Judge: what Judge does up front, then a checkbox list that reads as a choice. Ready: the harness template's four example prompts as cards that open a new chat with the message, agent profile and model ready; served by console::onboarding::prompts when the ADE has it, built in otherwise. The guided tour stays. - compose::add and compose::remove name the file the daemon loaded (compose::list), so a daemon started with --file from another directory no longer fails with "no worker-compose.yaml here". Guided tour (onboarding/ui): the same system — a vertical stepper with the open step's content in a card under its title, pill chips for state, the trigger as a disclosure onto a terminal block, grid-track expand/collapse that can reverse midway, and the console sans at the dialog's scale. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
skill-check — worker0 verified, 82 skipped (no docs/).
Three for three. Nicely done. |
Large fills in the setup dialog and the tour — cards, rows, strips, the code surface, the soft secondary button — use the neutral palette one step per theme instead of the alpha surface ramp, which read as a grey slab across a whole card in the light theme. A checked card is neutral-100 with a neutral-400 stroke (neutral-900 with neutral-600 in the dark theme). Small controls keep surface-hover. The command and engine-log blocks are a light panel with dark code colours in the light theme and the raised dark panel in the dark theme, in both the dialog and the tour. Ready no longer lists where the keys live: that line read as jargon. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Owner
Author
|
Superseded by iii-hq#1367, opened against the main repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesign of the first-run setup dialog (
ade/web/src/components/onboarding) and the guided tour page (onboarding/ui) so both read as one system.Setup dialog
aria-current="step"; steps ahead are plain text so Tab only stops on things that act. Below the@lgcontainer width the rail becomes a one-row stepper.console::onboarding::promptswhen the ADE has it (upstream feat: onboarding feedback — Chromium setup step, pinned response language, ports, and no polling iii-hq/workers#1329), built in otherwise. The guided tour offer stays.compose::addandcompose::removenow pass the file the daemon loaded (fromcompose::list), so a daemon started with--filefrom another directory no longer fails with "no worker-compose.yaml here".Guided tour
Same system: a vertical stepper with the open step's content in a card under its title, pill chips for state, the trigger as a disclosure onto a terminal block, grid-track expand/collapse that can reverse midway, the console sans at the dialog's 13px scale. No nested scroll containers.
Verification
pnpm typecheck, Biome on the onboarding directories, and the onboarding unit tests (64) pass; the full web suite passes apart from two pre-existing flaky cases unrelated to this change (ProviderConfigurationPanel,MermaidDiagram).Notes
harness/worker-compose.yamlis intentionally not part of this PR (local wizard-made changes).onboardingpackage needs a release for the tour redesign to reach a project that installs it from the registry.iii-hq/workersmain has since reworked the same files (feat: providers declare default models and thinking levels; harness and ADE start on them iii-hq/workers#1306, feat: onboarding feedback — Chromium setup step, pinned response language, ports, and no polling iii-hq/workers#1329, feat(ade): offer Decisions by OpenAI and Clef as Judge options in the setup wizard (MOT-5346) iii-hq/workers#1360); a dry-run merge shows conflicts inplan.ts,plan.test.ts,prompts.ts,prompts.test.tsandonboarding/ui/src/page.tsx. This PR targets the fork's main, which it merges cleanly into.🤖 Generated with Claude Code