fix(footer): try to use new locale changes

ariellalgilmore · Nov 8, 2023 · 000202b · 000202b
1 parent 4802032
commit 000202b
Showing 1 changed file with 20 additions and 14 deletions.
diff --git a/packages/web-components/src/components/footer/footer-composite.ts b/packages/web-components/src/components/footer/footer-composite.ts
@@ -66,16 +66,16 @@ class C4DFooterComposite extends MediaQueryMixin(
   /**
    * Handles `click` event on the locale button.
    */
-  private _handleClickLocaleButton = () => {
+  private async _handleClickLocaleButton() {
     this.openLocaleModal = true;
 
     // Set 'open' attribute after modal is in dom so CSS can fade it in.
-    // await this.updateComplete;
+    await this.updateComplete;
     const composite = this.modalRenderRoot?.querySelector(
       'c4d-locale-modal-composite'
     );
     composite?.setAttribute('open', '');
-  };
+  }
 
   @state()
   _isMobile = this.carbonBreakpoints.lg.matches;
@@ -205,11 +205,16 @@ class C4DFooterComposite extends MediaQueryMixin(
   @property({ attribute: false })
   localeList?: LocaleList;
 
+  /**
+   * @inheritdoc
+   */
+  modalTriggerProps = ['openLocaleModal', 'localeList'];
+
   /**
    * `true` to open the locale modal.
    */
   @property({ type: Boolean, attribute: 'open-locale-modal' })
-  openLocaleModal = false;
+  openLocaleModal;
 
   /**
    * Footer size.
@@ -260,16 +265,17 @@ class C4DFooterComposite extends MediaQueryMixin(
       openLocaleModal,
       _loadLocaleList: loadLocaleList,
     } = this;
-    return html`
-      <c4d-locale-modal-composite
-        lang-display="${ifDefined(langDisplay)}"
-        language="${ifDefined(language)}"
-        ?open="${openLocaleModal}"
-        .collatorCountryName="${ifDefined(collatorCountryName)}"
-        .localeList="${ifDefined(localeList)}"
-        ._loadLocaleList="${ifDefined(loadLocaleList)}">
-      </c4d-locale-modal-composite>
-    `;
+    return openLocaleModal
+      ? html`
+          <c4d-locale-modal-composite
+            lang-display="${ifDefined(langDisplay)}"
+            language="${ifDefined(language)}"
+            .collatorCountryName="${ifDefined(collatorCountryName)}"
+            .localeList="${ifDefined(localeList)}"
+            ._loadLocaleList="${ifDefined(loadLocaleList)}">
+          </c4d-locale-modal-composite>
+        `
+      : html``;
   }
 
   renderLanguageSelector(slot = 'language-selector') {