feat: add palette file, add palette tests #566
+3,573
−2,743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
argyleink
requested changes
Jan 6, 2026
Owner
argyleink
left a comment
argyleink
left a comment
There was a problem hiding this comment.
❤️ thanks for this!
you've got the files in there, and the tests look like they'll pass, but the one forgotten part was to add them to the main bundle and main JS object.
|
|
||
| test('Should have an all included import', t => { | ||
| t.is(Object.keys(OpenProps).length, 1778) | ||
| t.is(Object.keys(OpenProps).length, 1816) |
Owner
There was a problem hiding this comment.
main bundle doesnt include the new props because they're not in here https://github.com/argyleink/open-props/blob/main/build/props.js#L34
| t.assert(OpenProps.orange0) | ||
| }) | ||
|
|
||
| test('Import should have palette', async t => { |
Owner
There was a problem hiding this comment.
same with this test, it'll pass once the palette props are part of the JS main bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if the tests are used anymore, they are missing some stuff so I could remove that part of the PR (or fix them) - I didn't put much work into it before checking with you.
Step 2 in this PR is for sure the documentation, or it could be a completely new PR.