Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(normalize): add cursor: help to <abbr> element #522

Open
wants to merge 1 commit into
base: 2.0.0beta
Choose a base branch
from

Conversation

felix-bohlin
Copy link

Seems nice, doesn't it?

Copy link

stackblitz bot commented Nov 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@@ -334,6 +334,7 @@
}

:where(abbr) {
cursor: help;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cursor: help;
&[title] { cursor: help }

what about we only show this special cursor style if there's a title attribute worth hovering for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

Copy link
Author

@felix-bohlin felix-bohlin Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related/not related: should something similar be done for the <dfn> tag? The interaction is quite similar between the two?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants