Handle empty source strings in SourceReferenceExtractor#8121
Merged
Handle empty source strings in SourceReferenceExtractor#8121
Conversation
ekpyron
commented
Jan 9, 2020
|
|
||
| /// Constructs a SourceReference containing a message only. | ||
| static SourceReference MessageOnly(std::string _msg) | ||
| static SourceReference MessageOnly(std::string _msg, std::string _sourceName = {}) |
Collaborator
Author
There was a problem hiding this comment.
Let me know if you think it's unbearable to have something called MessageOnly optionally handle a source name as well, then I'll rename stuff :-).
chriseth
approved these changes
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may or may not be needed for proper reporting in #7153
But I think it's generally a good idea to have some safe-guards for handling cases like this gracefully.