Move states from the TypeChecker to the PostTypeChecker#8040
Merged
Move states from the TypeChecker to the PostTypeChecker#8040
Conversation
|
There was an error when running Please check that your changes are working as intended. |
Marenz
force-pushed
the
stateless-7566
branch
from
fb1464d to
cf612c7
Compare
chriseth
reviewed
Dec 17, 2019
| { | ||
| m_errorReporter.typeError( | ||
| _identifier.location(), | ||
| "Modifier can only be referenced in function headers." |
Contributor
There was a problem hiding this comment.
This is a check that makes sense to do before the type checker. It is more like a syntax check, only that it needs the reference resolver.
Contributor
There was a problem hiding this comment.
Ah maybe it's fine - the other checks are also all of that type.
Marenz
force-pushed
the
stateless-7566
branch
from
cf612c7 to
5c3c470
Compare
Contributor
|
Will rebase. |
chriseth
force-pushed
the
stateless-7566
branch
from
5c3c470 to
2179562
Compare
chriseth
approved these changes
Jan 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7566
based on #8038
This PR moves all states from the TypeChecker except the
m_scopeinto the PostTypechecker.I am not sure if we can and should remove
m_scopeas it seems rather heavily used in the class to do all kinds of analytics