Merged
Conversation
This comment has been minimized.
This comment has been minimized.
chriseth
force-pushed
the
codegenForObjectsAccess
branch
from
7a50ff3 to
56f1c3d
Compare
Contributor
Author
|
Updated. |
Codecov Report
@@ Coverage Diff @@
## develop #5616 +/- ##
===========================================
+ Coverage 88.12% 88.13% +<.01%
===========================================
Files 337 337
Lines 32386 32454 +68
Branches 3875 3884 +9
===========================================
+ Hits 28539 28602 +63
- Misses 2530 2539 +9
+ Partials 1317 1313 -4
|
chriseth
force-pushed
the
codegenForObjectsAccess
branch
from
56f1c3d to
5fbef0c
Compare
ekpyron
approved these changes
Dec 11, 2018
Collaborator
ekpyron
left a comment
ekpyron
left a comment
There was a problem hiding this comment.
I think this is fine - only a minor comment.
test/libyul/Parser.cpp
Outdated
| BOOST_AUTO_TEST_CASE(builtins_analysis) | ||
| { | ||
| struct SimpleBuiltinsAnalysis: public Builtins | ||
| struct SimpleDialectAnalysis: public Dialect |
Collaborator
There was a problem hiding this comment.
This struct itself doesn't analyze much, does it? Maybe it should just be called SimpleDialect, same as above?
ekpyron
requested changes
Dec 11, 2018
libyul/backends/evm/EVMDialect.cpp
Outdated
|
|
||
| addFunction("datasize", 1, 1, true, [this]( | ||
| FunctionCall const& _call, | ||
| AbstractAssembly& _asm, |
Collaborator
There was a problem hiding this comment.
It seems like you need to rename _asm for the windows build, though.
chriseth
force-pushed
the
codegenForObjectsAccess
branch
from
5fbef0c to
a7d0220
Compare
Contributor
Author
|
Two renames plus a rebase. |
ekpyron
previously approved these changes
Dec 11, 2018
chriseth
force-pushed
the
codegenForObjectsAccess
branch
from
a7d0220 to
1fc1c05
Compare
ekpyron
previously approved these changes
Dec 11, 2018
chriseth
force-pushed
the
codegenForObjectsAccess
branch
from
1fc1c05 to
fb3a0ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3334
Fixes #5510
This re-attaches the builtin function query function directly to the dialect and gets rid of the intermediate Builtins struct.
It also splits the Dialect into Dialect and EVMDialect. The latter returns a different BuiltinFuncitonForEVM (which derives from BuiltinFunction), which takes an AbstractAssembly for code generation.
After this change and relevant changes to the optimizer, we can turn all EVM instructions into builtin functions.